Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(439)

Unified Diff: third_party/WebKit/Source/core/frame/csp/MediaListDirective.h

Issue 2562953002: Part 5.2: Is policy list subsumed under subsuming policy? (Closed)
Patch Set: More test cases, removing .get() on members Created 4 years ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: third_party/WebKit/Source/core/frame/csp/MediaListDirective.h
diff --git a/third_party/WebKit/Source/core/frame/csp/MediaListDirective.h b/third_party/WebKit/Source/core/frame/csp/MediaListDirective.h
index c9e5cbf7b9e7668216458e525fb87904509b2b18..19226ae4069a68fb4cb3766a045e392d12617d59 100644
--- a/third_party/WebKit/Source/core/frame/csp/MediaListDirective.h
+++ b/third_party/WebKit/Source/core/frame/csp/MediaListDirective.h
@@ -21,11 +21,11 @@ class CORE_EXPORT MediaListDirective final : public CSPDirective {
MediaListDirective(const String& name,
const String& value,
ContentSecurityPolicy*);
- bool allows(const String& type);
+ bool allows(const String& type) const;
// The algorothm is described more extensively here:
// https://w3c.github.io/webappsec-csp/embedded/#subsume-policy.
- bool subsumes(const std::vector<MediaListDirective*>& other);
+ bool subsumes(const HeapVector<Member<MediaListDirective>>& other) const;
private:
FRIEND_TEST_ALL_PREFIXES(MediaListDirectiveTest, GetIntersect);
@@ -35,7 +35,7 @@ class CORE_EXPORT MediaListDirective final : public CSPDirective {
// The algorothm is described more extensively here:
// https://w3c.github.io/webappsec-csp/embedded/#subsume-policy.
- HashSet<String> getIntersect(const HashSet<String>& other);
+ HashSet<String> getIntersect(const HashSet<String>& other) const;
HashSet<String> m_pluginTypes;
};

Powered by Google App Engine
This is Rietveld 408576698