Use sdk summaries in front_end/kernel_generator.

pkg/front_end/tool/perf.dart

Index: pkg/front_end/tool/perf.dart
diff --git a/pkg/front_end/tool/perf.dart b/pkg/front_end/tool/perf.dart
index b8e9e63b96eef9d6c6a8a747798cc8b49057f7f1..4d7d61f0cbc90d3049422aa6783218c37d7902ad 100644
--- a/pkg/front_end/tool/perf.dart
+++ b/pkg/front_end/tool/perf.dart
@@ -27,6 +27,8 @@ import 'package:kernel/analyzer/loader.dart';
 import 'package:kernel/kernel.dart';
 import 'package:package_config/discovery.dart';
 
+import 'package:front_end/compiler_options.dart';
+import 'package:front_end/kernel_generator.dart';
 import 'package:front_end/src/scanner/reader.dart';
 import 'package:front_end/src/scanner/scanner.dart';
 import 'package:front_end/src/scanner/token.dart';
@@ -80,7 +82,21 @@ main(List<String> args) async {
       // TODO(sigmund): replace this warmup. Note that for very large programs,
       // the GC pressure on the VM seems to make this worse with time (maybe we
       // are leaking memory?). That's why we run it twice and not 10 times.
-      for (int i = 0; i < 2; i++) await generateKernel(entryUri);
+      for (int i = 0; i < 2; i++) {
+        await generateKernel(entryUri, useSdkSummary: false);
+      }
+    },
+    'kernel_gen_e2e_sum': () async {
+      // TODO(sigmund): remove. This is incorrect since it includes sizes for
+      // files that will not be loaded when using summaries. We need to extract
+      // input size from frontend instead.
+      scanReachableFiles(entryUri);
+      // TODO(sigmund): replace this warmup. Note that for very large programs,
+      // the GC pressure on the VM seems to make this worse with time (maybe we
+      // are leaking memory?). That's why we run it twice and not 10 times.
+      for (int i = 0; i < 2; i++) {
+        await generateKernel(entryUri, useSdkSummary: true);
+      }
     },
     'unlinked_summarize': () async {
       Set<Source> files = scanReachableFiles(entryUri);
@@ -403,24 +419,24 @@ void report(String name, int time) {
 }
 
 // TODO(sigmund): replace this once kernel is produced by the frontend directly.
-Future<Program> generateKernel(Uri entryUri) async {
+Future<Program> generateKernel(Uri entryUri,
+    {bool useSdkSummary: false}) async {
   var dartkTimer = new Stopwatch()..start();
-  var options = new DartOptions(strongMode: false, sdk: 'sdk');
-  var packages =
-      await createPackages(options.packagePath, discoveryPath: entryUri.path);
-  var repository = new Repository();
-  DartLoader loader = new DartLoader(repository, options, packages);
-
-  Program program = loader.loadProgram(entryUri);
-  List errors = loader.errors;
-  if (errors.isNotEmpty) {
-    const int errorLimit = 100;
-    stderr.writeln(errors.take(errorLimit).join('\n'));
-    if (errors.length > errorLimit) {
-      stderr.writeln('[error] ${errors.length - errorLimit} errors not shown');
-    }
+  // TODO(sigmund): expose strong mode in CompilerOptions until it's on by
+  // default?

[Paul Berry, 2016/12/09 13:41:40]

I was assuming we should just always use strong mode for this code; any work we
do on spec mode in the front end seems like wasted effort.

[Siggi Cherem (dart-lang), 2016/12/09 20:46:40]

discussed offline: we added another option for this.

The reason is that we need to support spec mode for a while longer in order to:
 - continue to have coverage with dartk of all language and co19 tests (until
language and co19 are strong clean)
 - make comparisons with existing tool chains more apples to apples.
The option will be deprecated once we are further along.

+  // TODO(sigmund): add a constructor with named args to compiler options.
+  var options = new CompilerOptions()..onError = ((e) => print('${e.message}'));
+  if (useSdkSummary) {
+    // TODO(sigmund): adjust path based on the benchmark runner architecture.
+    // Possibly let the runner make the file available at a architecture
+    // independent location.
+    options.sdkSummary = 'out/ReleaseX64/dart-sdk/lib/_internal/spec.sum';

[Paul Berry, 2016/12/09 13:41:40]

Same here--why not use "strong.sum"?

[Siggi Cherem (dart-lang), 2016/12/09 20:46:40]

Ditto

+  } else {
+    options.sdkPath = 'sdk';
   }
+  Program program = await kernelForBuildUnit([entryUri], options);
   dartkTimer.stop();
-  report("kernel_gen_e2e", dartkTimer.elapsedMicroseconds);
+  var suffix = useSdkSummary ? "_sum" : "";
+  report("kernel_gen_e2e${suffix}", dartkTimer.elapsedMicroseconds);
   return program;
 }