Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1636)

Unified Diff: content/browser/payments/payment_app.proto

Issue 2562873002: [PaymentApp] label field was changed to name field in PaymentAppOption. (Closed)
Patch Set: update test Created 4 years ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « components/payments/payment_app.mojom ('k') | content/browser/payments/payment_app_database.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: content/browser/payments/payment_app.proto
diff --git a/content/browser/payments/payment_app.proto b/content/browser/payments/payment_app.proto
index 3c740884c0ab2cec002aea0968963107d26b194a..1fd74fbdc932b7ddd6cc55098413e3622d2671d7 100644
--- a/content/browser/payments/payment_app.proto
+++ b/content/browser/payments/payment_app.proto
@@ -9,13 +9,13 @@ option optimize_for = LITE_RUNTIME;
package content;
message PaymentAppManifestProto {
- required string label = 1;
+ required string name = 1;
please use gerrit instead 2016/12/12 20:57:27 Let's make all these fields optional. These messa
Hwanseung Lee 2016/12/14 06:11:16 Done.
optional string icon = 2;
repeated PaymentAppOptionProto options = 3;
}
message PaymentAppOptionProto {
- required string label = 1;
+ required string name = 1;
optional string icon = 2;
required string id = 3;
repeated string enabled_methods = 4;
« no previous file with comments | « components/payments/payment_app.mojom ('k') | content/browser/payments/payment_app_database.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698