Replace CFX_WideStringCArray with std::vector.

Replace CFX_WideStringCArray with std::vector.

Committed: https://pdfium.googlesource.com/pdfium/+/94afac986c9d6232b7791acff4f23d99fbd004ae

[Tom Sepez, 2016-12-08 21:30:36]

The CQ bit was checked by tsepez@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-12-08 21:30:47]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[Tom Sepez, 2016-12-08 21:43:17]

tsepez@chromium.org changed reviewers:
+ dsinclair@chromium.org

[Tom Sepez, 2016-12-08 21:43:41]

The CQ bit was checked by tsepez@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-12-08 21:43:47]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[Tom Sepez, 2016-12-08 21:45:46]

Dan, ready for review.

[dsinclair, 2016-12-08 21:51:33]

lgtm w/ nit.

https://codereview.chromium.org/2562833002/diff/20001/xfa/fxfa/fm2js/xfa_expr...
File xfa/fxfa/fm2js/xfa_expression.h (right):

https://codereview.chromium.org/2562833002/diff/20001/xfa/fxfa/fm2js/xfa_expr...
xfa/fxfa/fm2js/xfa_expression.h:43: // Takes ownership of |pArguments| and
|pExpressions|.
Can you either rename these to |arguments| and |expressions| or rename the
variables to match these?

[commit-bot: I haz the power, 2016-12-08 21:56:37]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-12-08 21:56:38]

Dry run: This issue passed the CQ dry run.

[Tom Sepez, 2016-12-08 23:10:22]

https://codereview.chromium.org/2562833002/diff/20001/xfa/fxfa/fm2js/xfa_expr...
File xfa/fxfa/fm2js/xfa_expression.h (right):

https://codereview.chromium.org/2562833002/diff/20001/xfa/fxfa/fm2js/xfa_expr...
xfa/fxfa/fm2js/xfa_expression.h:43: // Takes ownership of |pArguments| and
|pExpressions|.
On 2016/12/08 21:51:33, dsinclair wrote:
> Can you either rename these to |arguments| and |expressions| or rename the
> variables to match these?

Done.  They are no longer pointers but rvalue references, no |p|.

[Tom Sepez, 2016-12-08 23:10:38]

The CQ bit was checked by tsepez@chromium.org

[Tom Sepez, 2016-12-08 23:10:39]

The patchset sent to the CQ was uploaded after l-g-t-m from
dsinclair@chromium.org
Link to the patchset: https://codereview.chromium.org/2562833002/#ps40001
(title: "comment")

[commit-bot: I haz the power, 2016-12-08 23:10:45]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-12-08 23:21:41]

CQ is committing da patch.

Bot data: {"patchset_id": 40001, "attempt_start_ts": 1481238638944310,
"parent_rev": "89ab499024b1f362b1d40dabd9fadded8b095203", "commit_rev":
"94afac986c9d6232b7791acff4f23d99fbd004ae"}

[commit-bot: I haz the power, 2016-12-08 23:21:45]

Description was changed from

==========
Replace CFX_WideStringCArray with std::vector.
==========

to

==========
Replace CFX_WideStringCArray with std::vector.

Committed:
https://pdfium.googlesource.com/pdfium/+/94afac986c9d6232b7791acff4f23d99fbd0...
==========

[commit-bot: I haz the power, 2016-12-08 23:21:45]

Committed patchset #3 (id:40001) as
https://pdfium.googlesource.com/pdfium/+/94afac986c9d6232b7791acff4f23d99fbd0...