Issue 25628004: Revert r223961 and r224074 (using IO message loop instead of DEFAULT).

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 25628004: Revert r223961 and r224074 (using IO message loop instead of DEFAULT). (Closed)

Created:
7 years, 2 months ago by piman

Modified:
7 years, 2 months ago

Reviewers:
jamesr

CC:
chromium-reviews, jbauman+watch_chromium.org, Ian Vollick, jam, sievers+watch_chromium.org, joi+watch-content_chromium.org, darin-cc_chromium.org, piman+watch_chromium.org, danakj+watch_chromium.org, cc-bugs_chromium.org

Base URL:
svn://svn.chromium.org/chrome/trunk/src

Visibility:
Public.

More Reviews

Description

Revert r223961 and r224074 (using IO message loop instead of DEFAULT). MessagePumpDefault was incorrectly using system time instead of monotonic time for PostDelayedTask. This was fixed in r226378 so we don't need this workaround any more. BUG=293736 Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=226425

Patch Set 1 #

Created: 7 years, 2 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+0 lines, -33 lines)			Patch
	M	content/renderer/render_thread_impl.cc	View		2 chunks	+0 lines, -22 lines	0 comments	Download
	M	ui/compositor/compositor.cc	View		1 chunk	+0 lines, -11 lines	0 comments	Download

Messages

Total messages: 4 (0 generated)

Expand Messages | Collapse Messages

jamesr

lgtm To unsubscribe from this group and stop receiving emails from it, send an email ...

7 years, 2 months ago (2013-10-02 03:20:22 UTC) #2

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/piman@chromium.org/25628004/1

7 years, 2 months ago (2013-10-02 03:26:14 UTC) #3

Message was sent while issue was closed.

Change committed as 226425

Expand Messages | Collapse Messages