Rebaseline after V8 roll for consolobject preview changes

Rebaseline after V8 roll for consolobject preview changes

Corresponding expectation CL: https://codereview.chromium.org/2555983002/

BUG=645053
Committed: https://crrev.com/4facd77b06c7baa20c963e6437246ca72e0584fe
Cr-Commit-Position: refs/heads/master@{#437370}

[luoe, 2016-12-08 18:49:28]

The CQ bit was checked by luoe@chromium.org to run a CQ dry run

[luoe, 2016-12-08 18:49:45]

luoe@chromium.org changed reviewers:
+ kozyatinskiy@chromium.org

[luoe, 2016-12-08 18:49:46]

Please take a look

[commit-bot: I haz the power, 2016-12-08 18:50:05]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[kozy, 2016-12-08 19:20:45]

lgtm

[kozy, 2016-12-08 19:23:16]

https://codereview.chromium.org/2562793002/diff/1/third_party/WebKit/LayoutTe...
File
third_party/WebKit/LayoutTests/inspector/console/console-format-expected.txt
(right):

https://codereview.chromium.org/2562793002/diff/1/third_party/WebKit/LayoutTe...
third_party/WebKit/LayoutTests/inspector/console/console-format-expected.txt:244:
console-format.html:7 Object {__defineGetter__: function, __defineSetter__:
function, hasOwnProperty: function, __lookupGetter__: function,
__lookupSetter__: function…}
I don't like this change :(
Are these functions starting with __ is enumerable?

[luoe, 2016-12-08 21:24:02]

On 2016/12/08 19:23:16, kozyatinskiy wrote:
>
https://codereview.chromium.org/2562793002/diff/1/third_party/WebKit/LayoutTe...
> File
> third_party/WebKit/LayoutTests/inspector/console/console-format-expected.txt
> (right):
> 
>
https://codereview.chromium.org/2562793002/diff/1/third_party/WebKit/LayoutTe...
>
third_party/WebKit/LayoutTests/inspector/console/console-format-expected.txt:244:
> console-format.html:7 Object {__defineGetter__: function, __defineSetter__:
> function, hasOwnProperty: function, __lookupGetter__: function,
> __lookupSetter__: function…}
> I don't like this change :(
> Are these functions starting with __ is enumerable?

No they __defineGetter__ and the rest are not enumerable.  However, we will only
be showing them in a preview if the user explicitly evaluates something like
"Object.prototype".  It will not appear when evaluating "{}"

[commit-bot: I haz the power, 2016-12-08 21:26:45]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-12-08 21:26:46]

Dry run: This issue passed the CQ dry run.

[luoe, 2016-12-08 22:29:01]

The CQ bit was checked by luoe@chromium.org

[commit-bot: I haz the power, 2016-12-08 22:29:32]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-12-08 22:37:40]

CQ is committing da patch.

Bot data: {"patchset_id": 1, "attempt_start_ts": 1481236141274940, "parent_rev":
"66be63138b4bd350fb74f16f8a44a7089230be4e", "commit_rev":
"50bddd14a23cddd47684bb966d6aceb3c3d587b1"}

[commit-bot: I haz the power, 2016-12-08 22:38:12]

Committed patchset #1 (id:1)

[commit-bot: I haz the power, 2016-12-08 22:41:01]

Description was changed from

==========
Rebaseline after V8 roll for consolobject preview changes

Corresponding expectation CL: https://codereview.chromium.org/2555983002/

BUG=645053
==========

to

==========
Rebaseline after V8 roll for consolobject preview changes

Corresponding expectation CL: https://codereview.chromium.org/2555983002/

BUG=645053

Committed: https://crrev.com/4facd77b06c7baa20c963e6437246ca72e0584fe
Cr-Commit-Position: refs/heads/master@{#437370}
==========

[commit-bot: I haz the power, 2016-12-08 22:41:02]

Patchset 1 (id:??) landed as
https://crrev.com/4facd77b06c7baa20c963e6437246ca72e0584fe
Cr-Commit-Position: refs/heads/master@{#437370}