Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(50)

Issue 2562783002: Fix collision calculation (Closed)

Created:
4 years ago by stevenjb
Modified:
4 years ago
Reviewers:
afakhry, xiyuan, michaelpg
CC:
chromium-reviews, dbeam+watch-options_chromium.org, michaelpg+watch-options_chromium.org, arv+watch_chromium.org, oshima+watch_chromium.org
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Options: Display: Fix collision calculation This is already fixed in MD Settings, but somehow the fix never made it to Options. BUG=671376 CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation Committed: https://crrev.com/15ba5056faebb0489da4b7a48930057914945115 Cr-Commit-Position: refs/heads/master@{#437414}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+23 lines, -21 lines) Patch
M chrome/browser/resources/options/chromeos/display_layout.js View 3 chunks +15 lines, -14 lines 0 comments Download
M chrome/browser/resources/options/chromeos/display_layout_manager_multi.js View 4 chunks +8 lines, -7 lines 0 comments Download

Messages

Total messages: 13 (7 generated)
stevenjb
4 years ago (2016-12-08 18:49:25 UTC) #3
stevenjb
+xiyuan@ who, iirc, reviewed the original options code. Whoever has time to review this first ...
4 years ago (2016-12-08 18:53:38 UTC) #5
xiyuan
lgtm +afakhry@ who is looking at a similar bug
4 years ago (2016-12-08 20:36:59 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2562783002/1
4 years ago (2016-12-08 20:49:04 UTC) #9
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years ago (2016-12-09 01:37:59 UTC) #11
commit-bot: I haz the power
4 years ago (2016-12-09 01:40:30 UTC) #13
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/15ba5056faebb0489da4b7a48930057914945115
Cr-Commit-Position: refs/heads/master@{#437414}

Powered by Google App Engine
This is Rietveld 408576698