Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(181)

Issue 2562713002: [DO NOT SUBMIT] Support allowpaymentrequest with out-of-process iframes (Closed)

Created:
4 years ago by please use gerrit instead
Modified:
4 years ago
Reviewers:
alexmos
CC:
chromium-reviews, rouslan+payments_chromium.org, mlamouri+watch-blink_chromium.org, blink-reviews-html_chromium.org, jam, dcheng, gogerald+paymentswatch_chromium.org, haraken, dglazkov+blink, darin-cc_chromium.org, blink-reviews, blink-reviews-api_chromium.org, kinuko+watch, sebsg+paymentswatch_chromium.org, pals
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

[DO NOT SUBMIT] Support allowpaymentrequest with out-of-process iframes BUG=669585 patch from issue 2545693002 at patchset 60001 (http://crrev.com/2545693002#ps60001)

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+117 lines, -10 lines) Patch
A chrome/browser/payments/site_per_process_payments_browsertest.cc View 1 chunk +67 lines, -0 lines 0 comments Download
M chrome/test/BUILD.gn View 1 chunk +1 line, -0 lines 0 comments Download
A chrome/test/data/payment_request_iframe.html View 1 chunk +6 lines, -0 lines 0 comments Download
A chrome/test/data/payment_request_main.html View 1 chunk +7 lines, -0 lines 0 comments Download
M content/common/frame_messages.h View 1 chunk +1 line, -0 lines 0 comments Download
M content/common/frame_owner_properties.h View 1 chunk +1 line, -0 lines 0 comments Download
M content/common/frame_owner_properties.cc View 4 chunks +5 lines, -1 line 0 comments Download
M content/public/test/browser_test_utils.cc View 1 chunk +1 line, -0 lines 0 comments Download
M third_party/WebKit/Source/core/frame/FrameOwner.h View 2 chunks +2 lines, -0 lines 0 comments Download
M third_party/WebKit/Source/core/html/HTMLFrameOwnerElement.h View 1 chunk +1 line, -0 lines 0 comments Download
M third_party/WebKit/Source/core/html/HTMLIFrameElement.h View 2 chunks +2 lines, -0 lines 0 comments Download
M third_party/WebKit/Source/core/html/HTMLIFrameElement.cpp View 1 chunk +5 lines, -0 lines 0 comments Download
M third_party/WebKit/Source/modules/payments/PaymentRequest.cpp View 1 chunk +2 lines, -6 lines 0 comments Download
M third_party/WebKit/Source/web/FrameLoaderClientImpl.cpp View 1 chunk +2 lines, -1 line 0 comments Download
M third_party/WebKit/Source/web/RemoteFrameOwner.h View 3 chunks +5 lines, -0 lines 0 comments Download
M third_party/WebKit/Source/web/RemoteFrameOwner.cpp View 1 chunk +1 line, -0 lines 0 comments Download
M third_party/WebKit/Source/web/WebFrame.cpp View 1 chunk +1 line, -0 lines 0 comments Download
M third_party/WebKit/Source/web/WebLocalFrameImpl.cpp View 1 chunk +2 lines, -1 line 0 comments Download
M third_party/WebKit/public/web/WebFrameOwnerProperties.h View 3 chunks +5 lines, -1 line 0 comments Download

Messages

Total messages: 4 (2 generated)
please use gerrit instead
Hi Alex, I'm trying to help write the test for the OOPIF check in PaymentRequest, ...
4 years ago (2016-12-08 15:11:00 UTC) #2
alexmos
4 years ago (2016-12-09 01:20:19 UTC) #3
On 2016/12/08 15:11:00, rouslan wrote:
> Hi Alex,
> 
> I'm trying to help write the test for the OOPIF check in PaymentRequest, but
I'm
> getting this error in console:
> 
> [54998:54998:1208/100513.100887:INFO:CONSOLE(1)] "Uncaught TypeError: Cannot
set
> property 'src' of null", source:  (1)
> 
> This points to improper setup, but I don't see who my code is different from
> everything else. Can you spot the difference that's causing this error?
> 
> Cheers,
> Rouslan

Hi Rouslan, I think the problem is that the main page is not loading properly
due to a cert error.  The HTTPS server only serves a valid cert for localhost --
see the comment on
https://cs.chromium.org/chromium/src/content/browser/site_per_process_browser....

If you add     
  command_line->AppendSwitch(switches::kIgnoreCertificateErrors);
to the test setup it should work.

Powered by Google App Engine
This is Rietveld 408576698