Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(12)

Issue 25627002: Docserver: when checking for the existence of an API on a branch, just look at (Closed)

Created:
7 years, 2 months ago by not at google - send to devlin
Modified:
7 years, 2 months ago
Reviewers:
Jeffrey Yasskin
CC:
chromium-reviews, chromium-apps-reviews_chromium.org, extensions-reviews_chromium.org
Visibility:
Public.

Description

Docserver: when checking for the existence of an API on a branch, just look at the filename, don't try to parse the whole JSON/IDL file unless absolutely necessary. Halves the time it takes to run a cron (it recently regressed). R=jyasskin@chromium.org NOTRY=true Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=226372

Patch Set 1 #

Patch Set 2 : revert some unnecessary stuff #

Total comments: 12

Patch Set 3 : jeffrey #

Unified diffs Side-by-side diffs Delta from patch set Stats (+91 lines, -59 lines) Patch
M chrome/common/extensions/docs/server2/api_schema_graph.py View 2 chunks +7 lines, -2 lines 0 comments Download
M chrome/common/extensions/docs/server2/app.yaml View 1 chunk +1 line, -1 line 0 comments Download
M chrome/common/extensions/docs/server2/availability_finder.py View 1 2 7 chunks +52 lines, -31 lines 0 comments Download
M chrome/common/extensions/docs/server2/branch_utility.py View 1 chunk +6 lines, -0 lines 0 comments Download
M chrome/common/extensions/docs/server2/cron.yaml View 1 chunk +1 line, -1 line 0 comments Download
M chrome/common/extensions/docs/server2/test_data/object_level_availability/tabs.py View 11 chunks +24 lines, -24 lines 0 comments Download

Messages

Total messages: 6 (0 generated)
not at google - send to devlin
7 years, 2 months ago (2013-10-01 22:56:15 UTC) #1
Jeffrey Yasskin
https://codereview.chromium.org/25627002/diff/3001/chrome/common/extensions/docs/server2/api_schema_graph.py File chrome/common/extensions/docs/server2/api_schema_graph.py (right): https://codereview.chromium.org/25627002/diff/3001/chrome/common/extensions/docs/server2/api_schema_graph.py#newcode26 chrome/common/extensions/docs/server2/api_schema_graph.py:26: return '%s%s' % (type(self).__name__, repr(self.__dict__)) This is going to ...
7 years, 2 months ago (2013-10-02 00:19:16 UTC) #2
not at google - send to devlin
https://codereview.chromium.org/25627002/diff/3001/chrome/common/extensions/docs/server2/api_schema_graph.py File chrome/common/extensions/docs/server2/api_schema_graph.py (right): https://codereview.chromium.org/25627002/diff/3001/chrome/common/extensions/docs/server2/api_schema_graph.py#newcode26 chrome/common/extensions/docs/server2/api_schema_graph.py:26: return '%s%s' % (type(self).__name__, repr(self.__dict__)) On 2013/10/02 00:19:17, Jeffrey ...
7 years, 2 months ago (2013-10-02 00:40:02 UTC) #3
Jeffrey Yasskin
lgtm
7 years, 2 months ago (2013-10-02 00:44:05 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/kalman@chromium.org/25627002/10001
7 years, 2 months ago (2013-10-02 00:46:32 UTC) #5
commit-bot: I haz the power
7 years, 2 months ago (2013-10-02 00:55:22 UTC) #6
Message was sent while issue was closed.
Change committed as 226372

Powered by Google App Engine
This is Rietveld 408576698