Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(230)

Side by Side Diff: src/heap/heap.cc

Issue 2562683002: Merged: [heap] Reland: Use store buffer for writes coming from mutator. (Closed)
Patch Set: Created 4 years ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « no previous file | src/heap/heap-inl.h » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright 2012 the V8 project authors. All rights reserved. 1 // Copyright 2012 the V8 project authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #include "src/heap/heap.h" 5 #include "src/heap/heap.h"
6 6
7 #include "src/accessors.h" 7 #include "src/accessors.h"
8 #include "src/api.h" 8 #include "src/api.h"
9 #include "src/ast/context-slot-cache.h" 9 #include "src/ast/context-slot-cache.h"
10 #include "src/base/bits.h" 10 #include "src/base/bits.h"
(...skipping 5872 matching lines...) Expand 10 before | Expand all | Expand 10 after
5883 void Heap::CheckHandleCount() { 5883 void Heap::CheckHandleCount() {
5884 CheckHandleCountVisitor v; 5884 CheckHandleCountVisitor v;
5885 isolate_->handle_scope_implementer()->Iterate(&v); 5885 isolate_->handle_scope_implementer()->Iterate(&v);
5886 } 5886 }
5887 5887
5888 void Heap::ClearRecordedSlot(HeapObject* object, Object** slot) { 5888 void Heap::ClearRecordedSlot(HeapObject* object, Object** slot) {
5889 if (!InNewSpace(object)) { 5889 if (!InNewSpace(object)) {
5890 Address slot_addr = reinterpret_cast<Address>(slot); 5890 Address slot_addr = reinterpret_cast<Address>(slot);
5891 Page* page = Page::FromAddress(slot_addr); 5891 Page* page = Page::FromAddress(slot_addr);
5892 DCHECK_EQ(page->owner()->identity(), OLD_SPACE); 5892 DCHECK_EQ(page->owner()->identity(), OLD_SPACE);
5893 store_buffer()->MoveAllEntriesToRememberedSet(); 5893 store_buffer()->DeleteEntry(slot_addr);
5894 RememberedSet<OLD_TO_NEW>::Remove(page, slot_addr);
5895 RememberedSet<OLD_TO_OLD>::Remove(page, slot_addr); 5894 RememberedSet<OLD_TO_OLD>::Remove(page, slot_addr);
5896 } 5895 }
5897 } 5896 }
5898 5897
5899 void Heap::ClearRecordedSlotRange(Address start, Address end) { 5898 void Heap::ClearRecordedSlotRange(Address start, Address end) {
5900 Page* page = Page::FromAddress(start); 5899 Page* page = Page::FromAddress(start);
5901 if (!page->InNewSpace()) { 5900 if (!page->InNewSpace()) {
5902 DCHECK_EQ(page->owner()->identity(), OLD_SPACE); 5901 DCHECK_EQ(page->owner()->identity(), OLD_SPACE);
5903 store_buffer()->MoveAllEntriesToRememberedSet(); 5902 store_buffer()->DeleteEntry(start, end);
5904 RememberedSet<OLD_TO_NEW>::RemoveRange(page, start, end,
5905 SlotSet::PREFREE_EMPTY_BUCKETS);
5906 RememberedSet<OLD_TO_OLD>::RemoveRange(page, start, end, 5903 RememberedSet<OLD_TO_OLD>::RemoveRange(page, start, end,
5907 SlotSet::FREE_EMPTY_BUCKETS); 5904 SlotSet::FREE_EMPTY_BUCKETS);
5908 } 5905 }
5909 } 5906 }
5910 5907
5911 void Heap::RecordWriteIntoCodeSlow(Code* host, RelocInfo* rinfo, 5908 void Heap::RecordWriteIntoCodeSlow(Code* host, RelocInfo* rinfo,
5912 Object* value) { 5909 Object* value) {
5913 DCHECK(InNewSpace(value)); 5910 DCHECK(InNewSpace(value));
5914 Page* source_page = Page::FromAddress(reinterpret_cast<Address>(host)); 5911 Page* source_page = Page::FromAddress(reinterpret_cast<Address>(host));
5915 RelocInfo::Mode rmode = rinfo->rmode(); 5912 RelocInfo::Mode rmode = rinfo->rmode();
(...skipping 552 matching lines...) Expand 10 before | Expand all | Expand 10 after
6468 } 6465 }
6469 6466
6470 6467
6471 // static 6468 // static
6472 int Heap::GetStaticVisitorIdForMap(Map* map) { 6469 int Heap::GetStaticVisitorIdForMap(Map* map) {
6473 return StaticVisitorBase::GetVisitorId(map); 6470 return StaticVisitorBase::GetVisitorId(map);
6474 } 6471 }
6475 6472
6476 } // namespace internal 6473 } // namespace internal
6477 } // namespace v8 6474 } // namespace v8
OLDNEW
« no previous file with comments | « no previous file | src/heap/heap-inl.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698