Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(193)

Issue 2562673003: [Sync] WorkerEntityTracker: Ensure that update and commit response have valid id. (Closed)

Created:
4 years ago by pavely
Modified:
4 years ago
Reviewers:
maxbogue
CC:
chromium-reviews, sync-reviews_chromium.org
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

[Sync] WorkerEntityTracker: Ensure that update and commit response have valid id. This change enforces the check in ModelTypeWorker::AdjustCommitProto ensuring that id is set to valid string. R=maxbogue@chromium.org BUG=672100 step Committed: https://crrev.com/46bb6daf3f67cc9f04ddc14b165cb3c40a6ed7b0 Cr-Commit-Position: refs/heads/master@{#437411}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+5 lines, -6 lines) Patch
M components/sync/engine_impl/model_type_worker.cc View 2 chunks +2 lines, -2 lines 0 comments Download
M components/sync/engine_impl/worker_entity_tracker.cc View 3 chunks +3 lines, -4 lines 0 comments Download

Messages

Total messages: 14 (9 generated)
pavely
4 years ago (2016-12-08 23:11:38 UTC) #3
maxbogue
lgtm
4 years ago (2016-12-08 23:15:20 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2562673003/1
4 years ago (2016-12-08 23:45:14 UTC) #10
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years ago (2016-12-09 01:34:47 UTC) #12
commit-bot: I haz the power
4 years ago (2016-12-09 01:37:41 UTC) #14
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/46bb6daf3f67cc9f04ddc14b165cb3c40a6ed7b0
Cr-Commit-Position: refs/heads/master@{#437411}

Powered by Google App Engine
This is Rietveld 408576698