chrome/browser/ui/cocoa/ssl_client_certificate_selector_cocoa.mm - Issue 2562653002: Mac: Fix window ordering for certificate viewer/selector sheets and overlays.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/ui/cocoa/ssl_client_certificate_selector_cocoa.mm

Issue 2562653002: Mac: Fix window ordering for certificate viewer/selector sheets and overlays.

Patch Set: Switch to reordering the child window array instead of setting the window level manually. Created 4 years ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: chrome/browser/ui/cocoa/ssl_client_certificate_selector_cocoa.mm

diff --git a/chrome/browser/ui/cocoa/ssl_client_certificate_selector_cocoa.mm b/chrome/browser/ui/cocoa/ssl_client_certificate_selector_cocoa.mm

index aa06b2d989ff696541645153fad4f79cd81ca48b..59cec03290b79b57de2f544a6ddcca746c27bc12 100644

--- a/chrome/browser/ui/cocoa/ssl_client_certificate_selector_cocoa.mm

+++ b/chrome/browser/ui/cocoa/ssl_client_certificate_selector_cocoa.mm

@@ -293,6 +293,13 @@ void ClearTableViewDataSourcesIfNeeded(NSWindow*) {}

[[sheetWindow contentView] setAutoresizesSubviews:oldResizesSubviews_];

[sheetWindow setAlphaValue:1.0];

[sheetWindow setIgnoresMouseEvents:NO];

+ // Reorder child windows so the currently showing sheet/overlay is on top.

+ NSWindow* parent = [overlayWindow_ parentWindow];

+ [parent removeChildWindow:overlayWindow_];

+ [parent addChildWindow:overlayWindow_ ordered:NSWindowAbove];

+ [overlayWindow_ removeChildWindow:sheetWindow];

+ [overlayWindow_ addChildWindow:sheetWindow ordered:NSWindowAbove];

}

- (void)pulseSheet {