Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(935)

Unified Diff: chrome/browser/ui/cocoa/ssl_client_certificate_selector_cocoa.mm

Issue 2562653002: Mac: Fix window ordering for certificate viewer/selector sheets and overlays.
Patch Set: Switch to using NSFooWindowLevels. Created 4 years ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/ui/cocoa/ssl_client_certificate_selector_cocoa.mm
diff --git a/chrome/browser/ui/cocoa/ssl_client_certificate_selector_cocoa.mm b/chrome/browser/ui/cocoa/ssl_client_certificate_selector_cocoa.mm
index aa06b2d989ff696541645153fad4f79cd81ca48b..f9df99da2ec23aed0b8b0d5756bbf1e095a8af8e 100644
--- a/chrome/browser/ui/cocoa/ssl_client_certificate_selector_cocoa.mm
+++ b/chrome/browser/ui/cocoa/ssl_client_certificate_selector_cocoa.mm
@@ -286,6 +286,9 @@ void ClearTableViewDataSourcesIfNeeded(NSWindow*) {}
oldResizesSubviews_ = [[sheetWindow contentView] autoresizesSubviews];
[[sheetWindow contentView] setAutoresizesSubviews:NO];
+
+ // Ensure this overlay doesn't interfere with overlays with hidden sheets.
+ [overlayWindow_ setLevel:NSNormalWindowLevel];
}
- (void)unhideSheet {
@@ -293,6 +296,9 @@ void ClearTableViewDataSourcesIfNeeded(NSWindow*) {}
[[sheetWindow contentView] setAutoresizesSubviews:oldResizesSubviews_];
[sheetWindow setAlphaValue:1.0];
[sheetWindow setIgnoresMouseEvents:NO];
+
+ // Set the current overlay's level higher than overlays with hidden sheets.
+ [overlayWindow_ setLevel:NSFloatingWindowLevel];
}
- (void)pulseSheet {

Powered by Google App Engine
This is Rietveld 408576698