components/reading_list/core/BUILD.gn - Issue 2562643003: Enable RL by default

Side by Side Diff

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Side by Side Diff: components/reading_list/core/BUILD.gn

Issue 2562643003: Enable RL by default (Closed)

Patch Set: feedback Created 4 years ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

OLD	NEW
1 # Copyright 2016 The Chromium Authors. All rights reserved.	1 # Copyright 2016 The Chromium Authors. All rights reserved.

2 # Use of this source code is governed by a BSD-style license that can be	2 # Use of this source code is governed by a BSD-style license that can be

3 # found in the LICENSE file.	3 # found in the LICENSE file.

4	4

	5 import("//build/buildflag_header.gni")

	6 import("//components/reading_list/core/reading_list.gni")

	7

	8 buildflag_header("enable_flags") {
	sdefresne 2016/12/09 17:42:10 nit: please name the target after the header file nit: please name the target after the header file ("reading_list_enable_flags"), and move it below the "core" target (that is the main target for this BUILD.gn file). Olivier 2016/12/11 20:34:19 Done. Show quoted text On 2016/12/09 17:42:10, sdefresne wrote: > nit: please name the target after the header file ("reading_list_enable_flags"), > and move it below the "core" target (that is the main target for this BUILD.gn > file). Done.
	9 header = "reading_list_enable_flags.h"

	10 _enabled = is_ios && enable_reading_list

	11 flags = [ "ENABLE_READING_LIST=$_enabled" ]

	12 }

	13

5 source_set("core") {	14 source_set("core") {

6 sources = [	15 sources = [

7 "reading_list_switches.cc",	16 "reading_list_switches.cc",

8 "reading_list_switches.h",	17 "reading_list_switches.h",

9 ]	18 ]

10 deps = [	19 deps = [

	20 ":enable_flags",

11 "//base",	21 "//base",

12 ]	22 ]

13 }	23 }

OLD	NEW