Enable RL by default

ios/build/chrome_build.gni

 # Copyright 2016 The Chromium Authors. All rights reserved.
 # Use of this source code is governed by a BSD-style license that can be
 # found in the LICENSE file.
 
 import("//build/config/chrome_build.gni")
 import("//build/config/ios/ios_sdk.gni")
 import("//build/config/mac/symbols.gni")
+import("//components/reading_list/core/reading_list.gni")
 
 declare_args() {
   # Enable today extension.
   ios_enable_today_extension = true
 
   # Enable share extension.
-  ios_enable_share_extension = true
+  ios_enable_share_extension = enable_reading_list

[sdefresne, 2016/12/09 15:37:15]

This won't do what you expect it to do (it will take the default value, not the
override from args.gn). You need to leave it to true, fix the downstream bot to
override both variable, then remove use of ios_enable_share_extension from the
code in favor of enable_reading_list, then update the downstream bot to not
override ios_enable_share_extension, then remove the variable.

In general, you cannot have variable in a declare_args() depend on another
variable defined in another declare_args() (it does something, but not what you
would expect).

[Olivier, 2016/12/09 15:47:19]

I would like to be able to disable share_extension without disabling reading
list (e.g. if there is a signature issue) as Reading list can work without
ShareExtension.
Can I just let the default to true and ensure manually this stays consistent?

 
   # Value of the encryption export compliance code. See "Cryptography and
   # U.S. Export Compliance" in "Submitting the App to App Review" in the
   # Apple developer documentation (https://goo.gl/yv1xEF).
   ios_encryption_export_compliance_code = ""
 
   # List of plist templates to merge when generating chrome Info.plist.
   ios_chrome_info_plist_additions = []
 
   # List of plist templates to merge when generating chrome entitlements.
@@ skipping 23 matching lines @@
   url_unsecure_scheme = "googlechrome"
   url_x_callback_scheme = "googlechrome-x-callback"
 } else {
   chromium_short_name = "Chromium"
   url_channel_scheme = "chromium-dev"
   url_secure_scheme = "chromiums"
   url_ssoauth_scheme = "$ios_app_bundle_id_prefix.sso.chromium"
   url_unsecure_scheme = "chromium"
   url_x_callback_scheme = "chromium-x-callback"
 }