components/reading_list/core/reading_list.gni - Issue 2562643003: Enable RL by default

Side by Side Diff

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Side by Side Diff: components/reading_list/core/reading_list.gni

Issue 2562643003: Enable RL by default (Closed)

Patch Set: use gn flag Created 4 years ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View unified diff | Download patch

OLD	NEW
1 # Copyright 2016 The Chromium Authors. All rights reserved.	1 # Copyright 2016 The Chromium Authors. All rights reserved.

2 # Use of this source code is governed by a BSD-style license that can be	2 # Use of this source code is governed by a BSD-style license that can be

3 # found in the LICENSE file.	3 # found in the LICENSE file.

4	4

5 source_set("core") {	5 # This file declares build flags for Reading List.
	sdefresne 2016/12/09 15:10:59 Remove, this is obvious. Remove, this is obvious. Olivier 2016/12/09 15:27:38 Done. Show quoted text On 2016/12/09 15:10:59, sdefresne wrote: > Remove, this is obvious. Done.
6 sources = [	6

7 "reading_list_switches.cc",	7 declare_args() {

8 "reading_list_switches.h",	8 enable_reading_list = true
	sdefresne 2016/12/09 15:10:59 Can you add a comment to document this variable? M Can you add a comment to document this variable? Maybe something like this. # Controls whether reading list support is active or not. Currently only # supported on iOS (on other platforms, the variable is ignored). enable_reading_list = true The reason is that you can get a list of all variables with documentation by using "gn args --list out/xxx". For variables defined in declare_args, the documentation is the comment above the variable definition. Olivier 2016/12/09 15:27:38 Done. Show quoted text On 2016/12/09 15:10:59, sdefresne wrote: > Can you add a comment to document this variable? Maybe something like this. > > # Controls whether reading list support is active or not. Currently only > # supported on iOS (on other platforms, the variable is ignored). > enable_reading_list = true > > The reason is that you can get a list of all variables with documentation by > using "gn args --list out/xxx". For variables defined in declare_args, the > documentation is the comment above the variable definition. Done.
9 ]

10 deps = [

11 "//base",

12 ]

13 }	9 }

OLD	NEW

« components/reading_list/core/BUILD.gn ('K') | « components/reading_list/core/BUILD.gn ('k') | components/reading_list/core/reading_list_switches.h » ('j') | no next file with comments »