Chromium Code Reviews Chromium Code Reviews
Issue 2562643002:
Avoid visually transitioning on length CSS properties when zoom changes (Closed)
| Index: third_party/WebKit/LayoutTests/animations/transition-zoomed-length.html |
| diff --git a/third_party/WebKit/LayoutTests/animations/transition-zoomed-length.html b/third_party/WebKit/LayoutTests/animations/transition-zoomed-length.html |
| new file mode 100644 |
| index 0000000000000000000000000000000000000000..c3e1f7b22a9541326982ce1a27bf32f91c890746 |
| --- /dev/null |
| +++ b/third_party/WebKit/LayoutTests/animations/transition-zoomed-length.html |
| @@ -0,0 +1,86 @@ |
| +<!DOCTYPE html> |
| +<script src="../resources/testharness.js"></script> |
| +<script src="../resources/testharnessreport.js"></script> |
| +<style> |
| +#target { |
| + transition: 1s; |
| + border-style: solid; |
| + outline-style: solid; |
| + column-rule-style: solid; |
| +} |
| +</style> |
| +<div id="target"></div> |
| +<script> |
| +var lengthProperties = [ |
|
suzyh_UTC10 (ex-contributor)
2016/12/12 04:30:13
Is there a canonical source we can get this list o
alancutter (OOO until 2018)
2016/12/13 02:36:34
Not one I would be comfortable relying on not chan
|
| + 'baselineShift', |
| + 'borderBottomWidth', |
| + 'borderLeftWidth', |
| + 'borderRightWidth', |
| + 'borderTopWidth', |
| + 'bottom', |
| + 'cx', |
| + 'cy', |
| + 'flexBasis', |
| + 'height', |
| + 'left', |
| + 'letterSpacing', |
| + 'marginBottom', |
| + 'marginLeft', |
| + 'marginRight', |
| + 'marginTop', |
| + 'maxHeight', |
| + 'maxWidth', |
| + 'minHeight', |
| + 'minWidth', |
| + 'offsetDistance', |
| + 'outlineOffset', |
| + 'outlineWidth', |
| + 'paddingBottom', |
| + 'paddingLeft', |
| + 'paddingRight', |
| + 'paddingTop', |
| + 'perspective', |
| + 'r', |
| + 'right', |
| + 'rx', |
| + 'ry', |
| + 'shapeMargin', |
| + 'strokeDashoffset', |
| + 'strokeWidth', |
| + 'top', |
| + 'verticalAlign', |
| + 'webkitBorderHorizontalSpacing', |
| + 'webkitBorderVerticalSpacing', |
| + 'columnGap', |
| + 'columnRuleWidth', |
| + 'columnWidth', |
| + 'webkitPerspectiveOriginX', |
| + 'webkitPerspectiveOriginY', |
| + 'webkitTransformOriginX', |
| + 'webkitTransformOriginY', |
| + 'webkitTransformOriginZ', |
| + 'width', |
| + 'wordSpacing', |
| + 'x', |
| + 'y', |
| + 'lineHeight', |
| +]; |
| +var expected = {}; |
| +test(() => { |
|
suzyh_UTC10 (ex-contributor)
2016/12/12 04:30:13
This is not a test. Why can this not be written wi
alancutter (OOO until 2018)
2016/12/13 02:36:34
Without the test() wrapper if this code throws an
|
| + for (var property of lengthProperties) { |
| + target.style[property] = '10px'; |
| + expected[property] = getComputedStyle(target)[property]; |
| + } |
| + if (window.internals) { |
|
suzyh_UTC10 (ex-contributor)
2016/12/12 04:30:13
Please add a comment to explain what these two opt
alancutter (OOO until 2018)
2016/12/13 02:36:34
The working group is trying to get rid of the zoom
|
| + internals.setZoomFactor(2); |
| + } else { |
| + target.style.zoom = 2; |
| + } |
| +}, 'Test setup'); |
| + |
| +for (var property of lengthProperties) { |
| + test(() => { |
| + assert_equals(getComputedStyle(target)[property], expected[property]); |
| + }, 'Computed value of transitionable ' + property + ' should not change when zoom changes'); |
| +} |
| +</script> |
