Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(153)

Issue 2562633004: Wires up SimulateNativeDestroy for views-aura-mus (Closed)

Created:
4 years ago by sky
Modified:
4 years ago
Reviewers:
msw
CC:
chromium-reviews, tfarina
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Wires up SimulateNativeDestroy for views-aura-mus BUG=663868 TEST=test only change R=msw@chromium.org Committed: https://crrev.com/277e4d0850b3a22c4c51bcb57cb9ba315852778d Cr-Commit-Position: refs/heads/master@{#437336}

Patch Set 1 #

Total comments: 1
Unified diffs Side-by-side diffs Delta from patch set Stats (+7 lines, -3 lines) Patch
M ui/views/mus/views_aura_mus_test_suite.cc View 2 chunks +7 lines, -3 lines 1 comment Download

Messages

Total messages: 13 (7 generated)
sky
4 years ago (2016-12-08 17:01:01 UTC) #1
msw
lgtm with minor comment https://codereview.chromium.org/2562633004/diff/1/ui/views/mus/views_aura_mus_test_suite.cc File ui/views/mus/views_aura_mus_test_suite.cc (right): https://codereview.chromium.org/2562633004/diff/1/ui/views/mus/views_aura_mus_test_suite.cc#newcode79 ui/views/mus/views_aura_mus_test_suite.cc:79: static_cast<aura::WindowTreeClientDelegate*>(mus_client_.get()) Unfortunate that we need ...
4 years ago (2016-12-08 20:16:38 UTC) #6
sky
On 2016/12/08 20:16:38, msw wrote: > lgtm with minor comment > > https://codereview.chromium.org/2562633004/diff/1/ui/views/mus/views_aura_mus_test_suite.cc > File ...
4 years ago (2016-12-08 20:31:42 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2562633004/1
4 years ago (2016-12-08 20:33:15 UTC) #9
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years ago (2016-12-08 21:00:59 UTC) #11
commit-bot: I haz the power
4 years ago (2016-12-08 21:03:27 UTC) #13
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/277e4d0850b3a22c4c51bcb57cb9ba315852778d
Cr-Commit-Position: refs/heads/master@{#437336}

Powered by Google App Engine
This is Rietveld 408576698