Update save file button based on states

Update save file button based on states

On chrome://net-internals/#export, when you backspace really quickly and
save to file at almost the same time, then save button becomes enabled
even when the textarea is empty.

There are currently two paths to enable or disable save file button:
1) UserComments is empty or not empty.
2) We are saving button / not saving button.

Things can get wrong if the two paths conflict with each other.

In fixing this, we also change the function structure such that save file
button is enabled / disabled based on both states.

BUG=671969
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation

Committed: https://crrev.com/1dfe6d2f4f55e4a344b51c16fe0fa23bd00f21a9
Cr-Commit-Position: refs/heads/master@{#437295}

[Changwan Ryu, 2016-12-08 07:49:23]

Description was changed from

==========
Update save file button based on states

On chrome://net-internals/#export, when you backspace really quickly and
save to file at almost the same time, then save button becomes enabled
even when the textarea is empty.

There are currently two paths to enable or disable save file button:
1) UserComments is empty or not empty.
2) We are saving button / not saving button.

Things can get wrong if the two paths conflict with each other.

In fixing this, we also change the function structure such that save file
button is enabled / disabled based on both states.

BUG=671969
==========

to

==========
Update save file button based on states

On chrome://net-internals/#export, when you backspace really quickly and
save to file at almost the same time, then save button becomes enabled
even when the textarea is empty.

There are currently two paths to enable or disable save file button:
1) UserComments is empty or not empty.
2) We are saving button / not saving button.

Things can get wrong if the two paths conflict with each other.

In fixing this, we also change the function structure such that save file
button is enabled / disabled based on both states.

BUG=671969
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation
==========

[Changwan Ryu, 2016-12-08 07:50:15]

changwan@chromium.org changed reviewers:
+ mmenke@chromium.org

[Changwan Ryu, 2016-12-08 07:50:15]

Fixing a regression in my previous CL. PTAL. Thanks!

[mmenke, 2016-12-08 15:13:32]

On 2016/12/08 07:50:15, Changwan Ryu wrote:
> Fixing a regression in my previous CL. PTAL. Thanks!

LGTM

[Changwan Ryu, 2016-12-08 16:36:19]

The CQ bit was checked by changwan@chromium.org

[commit-bot: I haz the power, 2016-12-08 16:37:02]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-12-08 17:57:42]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-12-08 17:57:43]

Try jobs failed on following builders:
  android_n5x_swarming_rel on master.tryserver.chromium.android (JOB_FAILED,
https://build.chromium.org/p/tryserver.chromium.android/builders/android_n5x_...)

[Changwan Ryu, 2016-12-08 18:10:19]

The CQ bit was checked by changwan@chromium.org

[commit-bot: I haz the power, 2016-12-08 18:10:51]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-12-08 18:50:49]

CQ is committing da patch.

Bot data: {"patchset_id": 1, "attempt_start_ts": 1481220619480030, "parent_rev":
"a3834275c28d03564b90ec9b8848b6c22635ac95", "commit_rev":
"096b19fe8abf6cedcb1823b824c7a581c734d8eb"}

[commit-bot: I haz the power, 2016-12-08 18:51:38]

Committed patchset #1 (id:1)

[commit-bot: I haz the power, 2016-12-08 18:53:32]

Description was changed from

==========
Update save file button based on states

On chrome://net-internals/#export, when you backspace really quickly and
save to file at almost the same time, then save button becomes enabled
even when the textarea is empty.

There are currently two paths to enable or disable save file button:
1) UserComments is empty or not empty.
2) We are saving button / not saving button.

Things can get wrong if the two paths conflict with each other.

In fixing this, we also change the function structure such that save file
button is enabled / disabled based on both states.

BUG=671969
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation
==========

to

==========
Update save file button based on states

On chrome://net-internals/#export, when you backspace really quickly and
save to file at almost the same time, then save button becomes enabled
even when the textarea is empty.

There are currently two paths to enable or disable save file button:
1) UserComments is empty or not empty.
2) We are saving button / not saving button.

Things can get wrong if the two paths conflict with each other.

In fixing this, we also change the function structure such that save file
button is enabled / disabled based on both states.

BUG=671969
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation

Committed: https://crrev.com/1dfe6d2f4f55e4a344b51c16fe0fa23bd00f21a9
Cr-Commit-Position: refs/heads/master@{#437295}
==========

[commit-bot: I haz the power, 2016-12-08 18:53:33]

Patchset 1 (id:??) landed as
https://crrev.com/1dfe6d2f4f55e4a344b51c16fe0fa23bd00f21a9
Cr-Commit-Position: refs/heads/master@{#437295}