Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(70)

Issue 2562623005: mus/gpu: Rename the client/server side memory buffer managers. (Closed)

Created:
4 years ago by sadrul
Modified:
4 years ago
Reviewers:
Fady Samuel, sky
CC:
chromium-reviews, rjkroege, qsr+mojo_chromium.org, viettrungluu+watch_chromium.org, yzshen+watch_chromium.org, abarth-chromium, Aaron Boodman, piman+watch_chromium.org, darin (slow to review)
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

mus/gpu: Rename the client/server side memory buffer managers. Rename MojoGpuMemoryBufferManager to ClientGpuMemoryBufferManager. Rename MusGpuMemoryBufferManager to ServerGpuMemoryBufferManager. BUG=none Committed: https://crrev.com/301ad2f8d2533080ab401d6685d7d9ec5f2ba2a8 Cr-Commit-Position: refs/heads/master@{#437438}

Patch Set 1 #

Total comments: 2

Patch Set 2 : tot merge #

Unified diffs Side-by-side diffs Delta from patch set Stats (+62 lines, -459 lines) Patch
M services/ui/common/BUILD.gn View 1 chunk +2 lines, -2 lines 0 comments Download
D services/ui/common/mus_gpu_memory_buffer_manager.h View 1 chunk +0 lines, -73 lines 0 comments Download
D services/ui/common/mus_gpu_memory_buffer_manager.cc View 1 chunk +0 lines, -104 lines 0 comments Download
A + services/ui/common/server_gpu_memory_buffer_manager.h View 3 chunks +10 lines, -10 lines 0 comments Download
A + services/ui/common/server_gpu_memory_buffer_manager.cc View 8 chunks +10 lines, -10 lines 0 comments Download
M services/ui/gpu/gpu_main.cc View 1 2 chunks +2 lines, -2 lines 0 comments Download
M services/ui/public/cpp/gpu/BUILD.gn View 1 chunk +2 lines, -2 lines 0 comments Download
A + services/ui/public/cpp/gpu/client_gpu_memory_buffer_manager.h View 3 chunks +9 lines, -9 lines 0 comments Download
A + services/ui/public/cpp/gpu/client_gpu_memory_buffer_manager.cc View 8 chunks +16 lines, -16 lines 0 comments Download
M services/ui/public/cpp/gpu/gpu_service.h View 2 chunks +2 lines, -2 lines 0 comments Download
M services/ui/public/cpp/gpu/gpu_service.cc View 2 chunks +3 lines, -3 lines 0 comments Download
D services/ui/public/cpp/gpu/mojo_gpu_memory_buffer_manager.h View 1 chunk +0 lines, -68 lines 0 comments Download
D services/ui/public/cpp/gpu/mojo_gpu_memory_buffer_manager.cc View 1 chunk +0 lines, -152 lines 0 comments Download
M services/ui/ws/gpu_service_proxy.h View 1 2 chunks +2 lines, -2 lines 0 comments Download
M services/ui/ws/gpu_service_proxy.cc View 1 4 chunks +4 lines, -4 lines 0 comments Download

Messages

Total messages: 25 (13 generated)
sadrul
(As discussed in an earlier CL)
4 years ago (2016-12-08 17:50:52 UTC) #4
Fady Samuel
lgtm
4 years ago (2016-12-08 18:05:55 UTC) #5
sky
https://codereview.chromium.org/2562623005/diff/1/services/ui/common/server_gpu_memory_buffer_manager.h File services/ui/common/server_gpu_memory_buffer_manager.h (right): https://codereview.chromium.org/2562623005/diff/1/services/ui/common/server_gpu_memory_buffer_manager.h#newcode21 services/ui/common/server_gpu_memory_buffer_manager.h:21: class ServerGpuMemoryBufferManager : public gpu::GpuMemoryBufferManager, Does this need to ...
4 years ago (2016-12-08 20:11:05 UTC) #8
sadrul
https://codereview.chromium.org/2562623005/diff/1/services/ui/common/server_gpu_memory_buffer_manager.h File services/ui/common/server_gpu_memory_buffer_manager.h (right): https://codereview.chromium.org/2562623005/diff/1/services/ui/common/server_gpu_memory_buffer_manager.h#newcode21 services/ui/common/server_gpu_memory_buffer_manager.h:21: class ServerGpuMemoryBufferManager : public gpu::GpuMemoryBufferManager, On 2016/12/08 20:11:04, sky ...
4 years ago (2016-12-08 20:28:34 UTC) #9
sky
I tend to think shared code for the servers should live else where, but we ...
4 years ago (2016-12-08 20:33:48 UTC) #10
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2562623005/1
4 years ago (2016-12-08 20:43:00 UTC) #12
commit-bot: I haz the power
Try jobs failed on following builders: android_n5x_swarming_rel on master.tryserver.chromium.android (JOB_FAILED, https://build.chromium.org/p/tryserver.chromium.android/builders/android_n5x_swarming_rel/builds/82700)
4 years ago (2016-12-08 21:50:10 UTC) #14
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2562623005/1
4 years ago (2016-12-08 22:34:29 UTC) #16
commit-bot: I haz the power
Try jobs failed on following builders: chromium_presubmit on master.tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/chromium_presubmit/builds/321992)
4 years ago (2016-12-08 22:51:13 UTC) #18
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2562623005/20001
4 years ago (2016-12-09 00:44:52 UTC) #21
commit-bot: I haz the power
Committed patchset #2 (id:20001)
4 years ago (2016-12-09 02:25:57 UTC) #23
commit-bot: I haz the power
4 years ago (2016-12-09 02:28:16 UTC) #25
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/301ad2f8d2533080ab401d6685d7d9ec5f2ba2a8
Cr-Commit-Position: refs/heads/master@{#437438}

Powered by Google App Engine
This is Rietveld 408576698