appengine/findit/crash/changelist_classifier.py - Issue 2562623004: Making CallStack immutable, so it can be hashable

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: appengine/findit/crash/changelist_classifier.py

Issue 2562623004: Making CallStack immutable, so it can be hashable (Closed)

Patch Set: Addressing nits Created 4 years ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: appengine/findit/crash/changelist_classifier.py

diff --git a/appengine/findit/crash/changelist_classifier.py b/appengine/findit/crash/changelist_classifier.py

index eb2abba2df226f7cd2c1ee16aadaa03c0228e2a7..47bf9062eba1a9c7ee6a76c6c8c2fdfd31328a51 100644

--- a/appengine/findit/crash/changelist_classifier.py

+++ b/appengine/findit/crash/changelist_classifier.py

@@ -58,12 +58,8 @@ class ChangelistClassifier(namedtuple('ChangelistClassifier',

last_good_version, first_bad_version)

# Restrict analysis to just the top n frames in each callstack.

- # TODO(wrengr): move this to be a Stacktrace method?

stacktrace = Stacktrace([

- CallStack(stack.priority,

- format_type=stack.format_type,

- language_type=stack.language_type,

- frame_list=stack[:self.top_n_frames])

+ stack.SliceFrames(None, self.top_n_frames)

for stack in report.stacktrace])

# We are only interested in the deps in crash stack (the callstack that