Making CallStack immutable, so it can be hashable

appengine/findit/crash/test/component_classifier_test.py

 # Copyright 2016 The Chromium Authors. All rights reserved.
 # Use of this source code is governed by a BSD-style license that can be
 # found in the LICENSE file.
 
 from common.pipeline_wrapper import pipeline_handlers
 from crash.stacktrace import StackFrame
 from crash.stacktrace import CallStack
 from crash.component_classifier import Component
 from crash.component_classifier import ComponentClassifier
 from crash.results import Result
@@ skipping 46 matching lines @@
     self.assertEqual(self.cccc.GetClassFromResult(result), '')
 
     result.file_to_stack_infos = {
         'comp1.cc': [
             (StackFrame(0, 'src/', 'func', 'comp1.cc', 'src/comp1.cc', [2]), 0)
         ]
     }
     self.assertEqual(self.cccc.GetClassFromResult(result), 'Comp1>Dummy')
 
   def testClassifyCrashStack(self):
-    crash_stack = CallStack(0)
-    crash_stack.extend([
+    crash_stack = CallStack(0, frame_list=[
         StackFrame(0, 'src/', 'func', 'comp1.cc', 'src/comp1.cc', [2]),
         StackFrame(1, 'src/', 'ff', 'comp1.cc', 'src/comp1.cc', [21]),
-        StackFrame(2, 'src/', 'func2', 'comp2.cc', 'src/comp2.cc', [8])
-    ])
+        StackFrame(2, 'src/', 'func2', 'comp2.cc', 'src/comp2.cc', [8])])
 
     self.assertEqual(self.cccc.Classify([], crash_stack),
                      ['Comp1>Dummy', 'Comp2>Dummy'])
 
   def testClassifyResults(self):
     result = Result(self.GetDummyChangeLog(), 'src/')
     result.file_to_stack_infos = {
         'comp1.cc': [
             (StackFrame(0, 'src/', 'func', 'comp1.cc', 'src/comp1.cc', [2]), 0)
         ]
     }
 
     self.assertEqual(self.cccc.Classify([result], CallStack(0)),
                      ['Comp1>Dummy'])
 
   def testClassifierDoNotHaveConfig(self):
     crash_config = CrashConfig.Get()
     crash_config.component_classifier = {}
     # N.B., we must construct a new cccc here, becasue we changed CrashConfig.
     self.cccc = CrashConfigComponentClassifier()
 
-    crash_stack = CallStack(0)
-    crash_stack.extend([
+    crash_stack = CallStack(0, frame_list=[
         StackFrame(0, 'src/', 'func', 'comp1.cc', 'src/comp1.cc', [2]),
         StackFrame(1, 'src/', 'ff', 'comp1.cc', 'src/comp1.cc', [21]),
-        StackFrame(2, 'src/', 'func2', 'comp2.cc', 'src/comp2.cc', [8])
-    ])
+        StackFrame(2, 'src/', 'func2', 'comp2.cc', 'src/comp2.cc', [8])])
 
     result = Result(self.GetDummyChangeLog(), 'src/')
     result.file_to_stack_infos = {
         'comp1.cc': [
             (StackFrame(0, 'src/', 'func', 'comp1.cc', 'src/comp1.cc', [2]), 0)
         ]
     }
 
     self.assertEqual(self.cccc.Classify([result], crash_stack), [])
 
@@ skipping 98 matching lines @@
             }
         ],
         'message': 'blabla...',
         'commit_url':
         'https://chromium.googlesource.com/chromium/src/+/git_hash',
         'code_review_url': 'https://codereview.chromium.org/2222',
         'reverted_revision': '8d4a4fa6s18raf3re12tg6r'})
     self.assertEqual(
         CrashConfigComponentClassifier().ClassifyChangeLog(change_log),
         [])