Making CallStack immutable, so it can be hashable

appengine/findit/crash/test/changelist_classifier_test.py

 # Copyright 2016 The Chromium Authors. All rights reserved.
 # Use of this source code is governed by a BSD-style license that can be
 # found in the LICENSE file.
 
 from collections import defaultdict
 import copy
 
 from common.dependency import Dependency
 from common.dependency import DependencyRoll
 from common import chrome_dependency_fetcher
 from crash import changelist_classifier
 from crash.crash_report import CrashReport
 from crash.results import AnalysisInfo
+from crash.results import StackInfo
 from crash.results import MatchResult
 from crash.stacktrace import CallStack
 from crash.stacktrace import StackFrame
 from crash.stacktrace import Stacktrace
 from crash.test.crash_test_suite import CrashTestSuite
 from libs.gitiles.blame import Blame
 from libs.gitiles.blame import Region
 from libs.gitiles.change_log import ChangeLog
 from libs.gitiles.gitiles_repository import GitilesRepository
 
@@ skipping 121 matching lines @@
     expected_regression_deps_rolls = copy.deepcopy(dep_rolls)
 
     # Regression of a dep added/deleted (old_revision/new_revision is None) can
     # not be known for sure and this case rarely happens, so just filter them
     # out.
     del expected_regression_deps_rolls['src/dep']
     self.assertEqual(passed_in_regression_deps_rolls[0],
                      expected_regression_deps_rolls)
 
   def testGetDepsInCrashStack(self):
-    crash_stack = CallStack(0)
-    crash_stack.extend([
+    crash_stack = CallStack(0, frame_list=[
         StackFrame(0, 'src/', 'func0', 'f0.cc', 'src/f0.cc', [1]),
         StackFrame(1, 'src/', 'func1', 'f1.cc', 'src/f1.cc', [2, 3]),
-        StackFrame(1, '', 'func2', 'f2.cc', 'src/f2.cc', [2, 3]),
-    ])
+        StackFrame(1, '', 'func2', 'f2.cc', 'src/f2.cc', [2, 3])])
     crash_deps = {'src/': Dependency('src/', 'https://chromium_repo', '1'),
                   'src/v8/': Dependency('src/v8/', 'https://v8_repo', '2')}
 
     expected_stack_deps = {'src/': crash_deps['src/']}
 
     self.assertDictEqual(
         changelist_classifier.GetDepsInCrashStack(crash_stack, crash_deps),
         expected_stack_deps)
 
   def testGetChangeLogsForFilesGroupedByDeps(self):
@@ skipping 31 matching lines @@
         'src/': {
             'a.cc': [DUMMY_CHANGELOG1.ToDict()],
             'f.cc': [DUMMY_CHANGELOG3.ToDict()]
         }
     }
     self.assertDictEqual(dep_file_to_changelogs_json,
                      expected_dep_file_to_changelogs_json)
     self.assertSetEqual(ignore_cls, set(['1']))
 
   def testGetStackInfosForFilesGroupedByDeps(self):
-    main_stack = CallStack(0)
-    main_stack.extend(
-        [StackFrame(0, 'src/', 'c(p* &d)', 'a.cc', 'src/a.cc', [177]),
-         StackFrame(1, 'src/', 'd(a* c)', 'a.cc', 'src/a.cc', [227, 228, 229]),
-         StackFrame(2, 'src/v8/', 'e(int)', 'b.cc', 'src/v8/b.cc', [89, 90])])
+    main_stack = CallStack(0, frame_list=[
+        StackFrame(0, 'src/', 'c(p* &d)', 'a.cc', 'src/a.cc', [177]),
+        StackFrame(1, 'src/', 'd(a* c)', 'a.cc', 'src/a.cc', [227, 228, 229]),
+        StackFrame(2, 'src/v8/', 'e(int)', 'b.cc', 'src/v8/b.cc', [89, 90])])
 
-    low_priority_stack = CallStack(1)
-    low_priority_stack.append(
-        StackFrame(0, 'src/dummy/', 'c(p* &d)', 'd.cc', 'src/dummy/d.cc', [17]))
+    low_priority_stack = CallStack(1, frame_list=[
+        StackFrame(0, 'src/dummy/', 'c(p* &d)', 'd.cc', 'src/dummy/d.cc',
+            [17])])
 
-    stacktrace = Stacktrace()
-    stacktrace.extend([main_stack, low_priority_stack])
+    stacktrace = Stacktrace(stack_list=[main_stack, low_priority_stack])
 
     crashed_deps = {'src/': Dependency('src/', 'https//repo', '2'),
                     'src/v8/': Dependency('src/v8', 'https//repo', '1')}
 
     expected_dep_file_to_stack_infos = {
         'src/': {
             'a.cc': [
-                (main_stack[0], 0),
-                (main_stack[1], 0),
+                StackInfo(main_stack.frames[0], 0),
+                StackInfo(main_stack.frames[1], 0),
             ],
         },
         'src/v8/': {
             'b.cc': [
-                (main_stack[2], 0),
+                StackInfo(main_stack.frames[2], 0),
             ]
         }
     }
 
     dep_file_to_stack_infos = (
         changelist_classifier.GetStackInfosForFilesGroupedByDeps(
             stacktrace, crashed_deps))
 
     self.assertEqual(len(dep_file_to_stack_infos),
                      len(expected_dep_file_to_stack_infos))
@@ skipping 13 matching lines @@
         'src/': {
             'a.cc': [
                 DUMMY_CHANGELOG1,
             ]
         }
     }
 
     dep_file_to_stack_infos = {
         'src/': {
             'a.cc': [
-                (StackFrame(0, 'src/', 'func', 'a.cc', 'src/a.cc', [1]), 0),
-                (StackFrame(1, 'src/', 'func', 'a.cc', 'src/a.cc', [7]), 0),
+                StackInfo(StackFrame(
+                    0, 'src/', 'func', 'a.cc', 'src/a.cc', [1]), 0),
+                StackInfo(StackFrame(
+                    1, 'src/', 'func', 'a.cc', 'src/a.cc', [7]), 0),
             ],
             'b.cc': [
-                (StackFrame(2, 'src/', 'func', 'b.cc', 'src/b.cc', [36]), 0),
+                StackInfo(StackFrame(
+                    2, 'src/', 'func', 'b.cc', 'src/b.cc', [36]), 0),
             ]
         }
     }
 
     dummy_blame = Blame('9', 'a.cc')
     dummy_blame.AddRegion(
         Region(1, 5, '6', 'a', 'a@chromium.org', 'Thu Mar 31 21:24:43 2016'))
     dummy_blame.AddRegion(
         Region(6, 10, '1', 'b', 'b@chromium.org', 'Thu Jun 19 12:11:40 2015'))
 
@@ skipping 41 matching lines @@
         'GetDependency', lambda *_: {})
     self.assertListEqual(self.changelist_classifier(DUMMY_REPORT), [])
 
   def testFindItForCrash(self):
 
     def _MockFindMatchResults(*_):
       match_result1 = MatchResult(DUMMY_CHANGELOG1, 'src/', '')
       frame1 = StackFrame(0, 'src/', 'func', 'a.cc', 'src/a.cc', [1])
       frame2 = StackFrame(1, 'src/', 'func', 'a.cc', 'src/a.cc', [7])
       match_result1.file_to_stack_infos = {
-          'a.cc': [(frame1, 0), (frame2, 0)]
+          'a.cc': [StackInfo(frame1, 0), StackInfo(frame2, 0)]
       }
       match_result1.file_to_analysis_info = {
           'a.cc': AnalysisInfo(min_distance=0, min_distance_frame=frame1)
       }
 
       match_result2 = MatchResult(DUMMY_CHANGELOG3, 'src/', '')
       frame3 = StackFrame(5, 'src/', 'func', 'f.cc', 'src/f.cc', [1])
       match_result2.file_to_stack_infos = {
-          'f.cc': [(frame3, 0)]
+          'f.cc': [StackInfo(frame3, 0)]
       }
       match_result2.file_to_analysis_info = {
           'a.cc': AnalysisInfo(min_distance=20, min_distance_frame=frame3)
       }
 
       return [match_result1, match_result2]
 
     self.mock(changelist_classifier, 'FindMatchResults', _MockFindMatchResults)
     self.mock(chrome_dependency_fetcher.ChromeDependencyFetcher,
         'GetDependencyRollsDict',
@@ skipping 17 matching lines @@
     ]
     self.assertListEqual([result.ToDict() for result in results],
                          expected_match_results)
 
   def testFinditForCrashFilterZeroConfidentResults(self):
     def _MockFindMatchResults(*_):
       match_result1 = MatchResult(DUMMY_CHANGELOG1, 'src/', '')
       frame1 = StackFrame(0, 'src/', 'func', 'a.cc', 'src/a.cc', [1])
       frame2 = StackFrame(1, 'src/', 'func', 'a.cc', 'src/a.cc', [7])
       match_result1.file_to_stack_infos = {
-          'a.cc': [(frame1, 0), (frame2, 0)]
+          'a.cc': [StackInfo(frame1, 0), StackInfo(frame2, 0)]
       }
       match_result1.file_to_analysis_info = {
           'a.cc': AnalysisInfo(min_distance=1, min_distance_frame=frame1)
       }
 
       match_result2 = MatchResult(DUMMY_CHANGELOG3, 'src/', '')
       frame3 = StackFrame(15, 'src/', 'func', 'f.cc', 'src/f.cc', [1])
       match_result2.file_to_stack_infos = {
-          'f.cc': [(frame3, 0)]
+          'f.cc': [StackInfo(frame3, 0)]
       }
       match_result2.file_to_analysis_info = {
           'f.cc': AnalysisInfo(min_distance=20, min_distance_frame=frame3)
       }
 
       match_result3 = MatchResult(DUMMY_CHANGELOG3, 'src/', '')
       frame4 = StackFrame(3, 'src/', 'func', 'ff.cc', 'src/ff.cc', [1])
       match_result3.file_to_stack_infos = {
-          'f.cc': [(frame4, 0)]
+          'f.cc': [StackInfo(frame4, 0)]
       }
       match_result3.file_to_analysis_info = {
           'f.cc': AnalysisInfo(min_distance=60, min_distance_frame=frame4)
       }
 
       return [match_result1, match_result2, match_result3]
 
     self.mock(changelist_classifier, 'FindMatchResults', _MockFindMatchResults)
     self.mock(chrome_dependency_fetcher.ChromeDependencyFetcher,
         'GetDependencyRollsDict',
@@ skipping 26 matching lines @@
     ]
     self.assertListEqual([result.ToDict() for result in results],
                          expected_match_results)
 
   def testFinditForCrashAllMatchResultsWithZeroConfidences(self):
     def _MockFindMatchResults(*_):
       match_result1 = MatchResult(DUMMY_CHANGELOG1, 'src/', '')
       frame1 = StackFrame(20, 'src/', '', 'func', 'a.cc', [1])
       frame2 = StackFrame(21, 'src/', '', 'func', 'a.cc', [7])
       match_result1.file_to_stack_infos = {
-          'a.cc': [(frame1, 0), (frame2, 0)]
+          'a.cc': [StackInfo(frame1, 0), StackInfo(frame2, 0)]
       }
       match_result1.file_to_analysis_info = {
           'a.cc': AnalysisInfo(min_distance=1, min_distance_frame=frame1)
       }
 
       match_result2 = MatchResult(DUMMY_CHANGELOG3, 'src/', '')
       frame3 = StackFrame(15, 'src/', '', 'func', 'f.cc', [1])
       match_result2.file_to_stack_infos = {
-          'f.cc': [(frame3, 0)]
+          'f.cc': [StackInfo(frame3, 0)]
       }
       match_result2.min_distance = 20
       match_result2.file_to_analysis_info = {
           'f.cc': AnalysisInfo(min_distance=20, min_distance_frame=frame3)
       }
 
       return [match_result1, match_result2]
 
     self.mock(changelist_classifier, 'FindMatchResults', _MockFindMatchResults)
     self.mock(chrome_dependency_fetcher.ChromeDependencyFetcher,
         'GetDependencyRollsDict',
         lambda *_: {'src/': DependencyRoll('src/', 'https://repo', '1', '2')})
     self.mock(chrome_dependency_fetcher.ChromeDependencyFetcher,
         'GetDependency', lambda *_: {})
 
     self.assertListEqual(self.changelist_classifier(DUMMY_REPORT), [])