appengine/findit/crash/callstack_filters.py - Issue 2562623004: Making CallStack immutable, so it can be hashable

Side by Side Diff

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Side by Side Diff: appengine/findit/crash/callstack_filters.py

Issue 2562623004: Making CallStack immutable, so it can be hashable (Closed)

Patch Set: Addressing nits Created 4 years ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

OLD	NEW
1 # Copyright 2016 The Chromium Authors. All rights reserved.	1 # Copyright 2016 The Chromium Authors. All rights reserved.

2 # Use of this source code is governed by a BSD-style license that can be	2 # Use of this source code is governed by a BSD-style license that can be

3 # found in the LICENSE file.	3 # found in the LICENSE file.

4	4

5 import re	5 import re

6	6

7 from crash.stacktrace import CallStack	7 from crash.stacktrace import CallStack

8	8

9	9

10 _INLINE_FUNCTION_FILE_PATH_MARKERS = [	10 _INLINE_FUNCTION_FILE_PATH_MARKERS = [

(...skipping 12 matching lines...) Expand all Loading...
23 def _IsNonInlineFunctionFrame(frame):	23 def _IsNonInlineFunctionFrame(frame):

24 for path_marker in _INLINE_FUNCTION_FILE_PATH_MARKERS:	24 for path_marker in _INLINE_FUNCTION_FILE_PATH_MARKERS:

25 if path_marker in frame.file_path:	25 if path_marker in frame.file_path:

26 return False	26 return False

27	27

28 return True	28 return True

29	29

30 return CallStack(callstack.priority,	30 return CallStack(callstack.priority,

31 callstack.format_type,	31 callstack.format_type,

32 callstack.language_type,	32 callstack.language_type,

33 filter(_IsNonInlineFunctionFrame, callstack))	33 filter(_IsNonInlineFunctionFrame, callstack.frames))

OLD	NEW

« no previous file with comments | « no previous file | appengine/findit/crash/changelist_classifier.py » ('j') | no next file with comments »