Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(118)

Issue 2562623003: Revert of Store OSR'd optimized code on the native context. (patchset #8 id:140001 of https://coder… (Closed)

Created:
4 years ago by Benedikt Meurer
Modified:
4 years ago
CC:
v8-reviews_googlegroups.com, v8-mips-ports_googlegroups.com, v8-x87-ports_googlegroups.com, Yang, v8-ppc-ports_googlegroups.com, rmcilroy
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

Revert of Store OSR'd optimized code on the native context. (patchset #8 id:140001 of https://codereview.chromium.org/2549753002/ ) Reason for revert: Speculative revert WebGL breakage reported in https://bugs.chromium.org/p/chromium/issues/detail?id=672367 Original issue's description: > Store OSR'd optimized code on the native context. > > Since we OSR code rarely, it makes sense to store it and look for it on the native context rather than the SharedFunctionInfo. This makes the OptimizedCodeMap data structure more space efficient, as it doesn't have to store an ast ID for the OSR entry point. > > BUG= > > Committed: https://crrev.com/378b6b22fb7925ac5b672335a54599f5739e7758 > Cr-Commit-Position: refs/heads/master@{#41554} TBR=mstarzinger@chromium.org, mvstanton@chromium.org, ulan@chromium.org BUG= Committed: https://crrev.com/b5f27ef30c86e48853474aa4d5a126ff62ee10f5 Cr-Commit-Position: refs/heads/master@{#41571}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+90 lines, -272 lines) Patch
M src/bootstrapper.cc View 1 chunk +0 lines, -2 lines 0 comments Download
M src/builtins/arm/builtins-arm.cc View 1 chunk +6 lines, -0 lines 0 comments Download
M src/builtins/arm64/builtins-arm64.cc View 1 chunk +6 lines, -0 lines 0 comments Download
M src/builtins/ia32/builtins-ia32.cc View 1 chunk +6 lines, -0 lines 0 comments Download
M src/builtins/mips/builtins-mips.cc View 1 chunk +5 lines, -0 lines 0 comments Download
M src/builtins/mips64/builtins-mips64.cc View 1 chunk +5 lines, -0 lines 0 comments Download
M src/builtins/x64/builtins-x64.cc View 1 chunk +7 lines, -0 lines 0 comments Download
M src/contexts.h View 2 chunks +0 lines, -22 lines 0 comments Download
M src/contexts.cc View 1 chunk +0 lines, -176 lines 0 comments Download
M src/contexts-inl.h View 1 chunk +0 lines, -3 lines 0 comments Download
M src/debug/debug.cc View 1 chunk +0 lines, -3 lines 0 comments Download
M src/isolate.h View 1 chunk +0 lines, -6 lines 0 comments Download
M src/isolate.cc View 1 chunk +0 lines, -20 lines 0 comments Download
M src/objects.h View 3 chunks +7 lines, -3 lines 0 comments Download
M src/objects.cc View 6 chunks +44 lines, -33 lines 0 comments Download
M test/cctest/interpreter/bytecode_expectations/CallRuntime.golden View 1 chunk +1 line, -1 line 0 comments Download
M test/cctest/interpreter/bytecode_expectations/SuperCallAndSpread.golden View 1 chunk +3 lines, -3 lines 0 comments Download

Messages

Total messages: 11 (6 generated)
Benedikt Meurer
4 years ago (2016-12-08 06:59:39 UTC) #1
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2562623003/1
4 years ago (2016-12-08 06:59:55 UTC) #6
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years ago (2016-12-08 07:29:10 UTC) #8
commit-bot: I haz the power
Patchset 1 (id:??) landed as https://crrev.com/b5f27ef30c86e48853474aa4d5a126ff62ee10f5 Cr-Commit-Position: refs/heads/master@{#41571}
4 years ago (2016-12-08 07:29:31 UTC) #10
mvstanton
4 years ago (2016-12-08 10:49:06 UTC) #11
Message was sent while issue was closed.
LGTM. Thanks for that catch, and sorry for the hassle. I actually caught this
bug during rebasing of another CL yesterday, and the fix was slowly making it's
way down the river :p.

Will resubmit with fix...
--Michael

Powered by Google App Engine
This is Rietveld 408576698