Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(13)

Unified Diff: third_party/WebKit/public/platform/modules/presentation/presentation.mojom

Issue 2562603002: Updates SessionMessage to ConnectionMessage. (Closed)
Patch Set: Created 4 years ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: third_party/WebKit/public/platform/modules/presentation/presentation.mojom
diff --git a/third_party/WebKit/public/platform/modules/presentation/presentation.mojom b/third_party/WebKit/public/platform/modules/presentation/presentation.mojom
index 0427db2c60e7d0709b13a1b4b2bbbeea73563084..8b404cb09f72c0b2689ad842309ba35a1b72dc36 100644
--- a/third_party/WebKit/public/platform/modules/presentation/presentation.mojom
+++ b/third_party/WebKit/public/platform/modules/presentation/presentation.mojom
@@ -40,15 +40,14 @@ struct PresentationError {
enum PresentationMessageType {
TEXT,
- ARRAY_BUFFER,
- BLOB,
+ BINARY,
};
-struct SessionMessage {
+struct ConnectionMessage {
PresentationMessageType type;
// Used when message type is TEXT.
string? message;
- // Used when message type is ARRAY_BUFFER or BLOB.
+ // Used when message type is BINARY.
dcheng 2016/12/13 08:25:14 Please add a TODO to make this a mojo union (I'd s
CJ 2016/12/13 22:05:35 Done. Ah is this related to your other comment?
array<uint8>? data;
};
@@ -95,8 +94,8 @@ interface PresentationService {
// The false in the result callback notifies the renderer to stop sending
// the send requests and invalidate all pending requests. This occurs
// for eg., when frame is deleted or navigated away.
- SendSessionMessage(PresentationSessionInfo sessionInfo,
- SessionMessage message_request) => (bool success);
+ SendConnectionMessage(PresentationSessionInfo sessionInfo,
+ ConnectionMessage message_request) => (bool success);
// Called when close() is called by the frame.
CloseConnection(url.mojom.Url presentation_url, string presentation_id);
@@ -106,9 +105,9 @@ interface PresentationService {
// Starts listening for messages for session with |sessionInfo|.
// Messages will be received in
- // PresentationServiceClient::OnSessionMessagesReceived.
+ // PresentationServiceClient::OnConnectionMessagesReceived.
// This is called after a presentation session is created.
- ListenForSessionMessages(PresentationSessionInfo sessionInfo);
+ ListenForConnectionMessages(PresentationSessionInfo sessionInfo);
};
interface PresentationServiceClient {
@@ -135,9 +134,9 @@ interface PresentationServiceClient {
PresentationConnectionCloseReason reason,
string message);
- // See PresentationService::ListenForSessionMessages.
- OnSessionMessagesReceived(PresentationSessionInfo sessionInfo,
- array<SessionMessage> messages);
+ // See PresentationService::ListenForConnectionMessages.
+ OnConnectionMessagesReceived(PresentationSessionInfo sessionInfo,
+ array<ConnectionMessage> messages);
// See PresentationService::SetDefaultPresentationURL.
OnDefaultSessionStarted(PresentationSessionInfo sessionInfo);

Powered by Google App Engine
This is Rietveld 408576698