tools/dom/scripts/systemnative.py - Issue 25626002: Generate a library ID instead of a library name, so that the ID can be used

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: tools/dom/scripts/systemnative.py

Issue 25626002: Generate a library ID instead of a library name, so that the ID can be used (Closed) Base URL: http://dart.googlecode.com/svn/branches/bleeding_edge/dart/

Patch Set: Created 7 years, 2 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: tools/dom/scripts/systemnative.py

===================================================================

--- tools/dom/scripts/systemnative.py (revision 28179)

+++ tools/dom/scripts/systemnative.py (working copy)

@@ -364,7 +364,7 @@

WEBCORE_CLASS_NAME_ESCAPED=

self._interface_type_info.native_type().replace('<', '_').replace('>', '_'),

DART_IMPLEMENTATION_CLASS=self._interface_type_info.implementation_name(),

- DART_IMPLEMENTATION_LIBRARY='dart:%s' % self._renamer.GetLibraryName(self._interface))

+ DART_IMPLEMENTATION_LIBRARY_ID='Dart%sLibraryId' % self._renamer.GetLibraryId(self._interface))

def _GenerateCPPHeader(self):

to_native_emitter = emitter.Emitter()

@@ -449,7 +449,8 @@

to_dart_emitter.Emit(

' static Dart_Handle createWrapper(NativeType* value)\n'

' {\n'

- ' return DartDOMWrapper::createWrapper<Dart$(INTERFACE)>(value);\n'

+ ' DartDOMData* domData = DartDOMData::current();\n'

+ ' return DartDOMWrapper::createWrapper<Dart$(INTERFACE)>(domData, value);\n'

' }\n',

INTERFACE=self._interface.id)

« tools/dom/scripts/htmlrenamer.py ('K') | « tools/dom/scripts/htmlrenamer.py ('k') | tools/dom/templates/html/dartium/cpp_header.template » ('j') | no next file with comments »