Chromium Code Reviews
|
|
Chromium Code Reviews
Issue
2562543002:
Add media/avtrack/video-track-selected.html to Windows RandomOrderExpectations (Closed)
DescriptionAdd media/avtrack/video-track-selected.html to Windows RandomOrderExpectations
It has failed 7 out of the last 20 builds.
BUG=672204
Committed: https://crrev.com/1e3956252e91599da90cc454ea6cd7ccac7c97fa
Cr-Commit-Position: refs/heads/master@{#437305}
Patch Set 1 #
Messages
Total messages: 18 (8 generated)
jeffcarp@chromium.org changed reviewers: + qyearsley@chromium.org
Description was changed from ========== Add media/avtrack/video-track-selected.html to Windows RandomOrderExpectations It has failed 7 out of the last 20 builds. BUG=672204 ========== to ========== Add media/avtrack/video-track-selected.html to Windows RandomOrderExpectations It has failed 7 out of the last 20 builds. BUG=672204 TBR=qyearsley@chromium.org ==========
The CQ bit was checked by jeffcarp@chromium.org
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
The CQ bit was unchecked by commit-bot@chromium.org
No L-G-T-M from a valid reviewer yet. CQ run can only be started by full committers or once the patch has received an L-G-T-M from a full committer. Even if an L-G-T-M may have been provided, it was from a non-committer, _not_ a full super star committer. See http://www.chromium.org/getting-involved/become-a-committer Note that this has nothing to do with OWNERS files.
On 2016/12/08 at 17:27:07, commit-bot wrote: > No L-G-T-M from a valid reviewer yet. > CQ run can only be started by full committers or once the patch has > received an L-G-T-M from a full committer. > Even if an L-G-T-M may have been provided, it was from a non-committer, > _not_ a full super star committer. > See http://www.chromium.org/getting-involved/become-a-committer > Note that this has nothing to do with OWNERS files. Oops, tried to pull a "these are not the droids you're looking for" with TBR but I'm not a committer so it still needs a review.
Description was changed from ========== Add media/avtrack/video-track-selected.html to Windows RandomOrderExpectations It has failed 7 out of the last 20 builds. BUG=672204 TBR=qyearsley@chromium.org ========== to ========== Add media/avtrack/video-track-selected.html to Windows RandomOrderExpectations It has failed 7 out of the last 20 builds. BUG=672204 ==========
On 2016/12/08 at 17:35:53, jeffcarp wrote: > On 2016/12/08 at 17:27:07, commit-bot wrote: > > No L-G-T-M from a valid reviewer yet. > > CQ run can only be started by full committers or once the patch has > > received an L-G-T-M from a full committer. > > Even if an L-G-T-M may have been provided, it was from a non-committer, > > _not_ a full super star committer. > > See http://www.chromium.org/getting-involved/become-a-committer > > Note that this has nothing to do with OWNERS files. > > Oops, tried to pull a "these are not the droids you're looking for" with TBR but I'm not a committer so it still needs a review. LGTM :-) Also, according to a strict reading of the official policy on TBR, I think that while this only affects FYI builds, we shouldn't use TBR to mark tests as flaky. "A developer (e.g. a sheriff) who is trying to correct a broken build can submit changes TBR=OWNER." - https://www.chromium.org/developers/owners-files#TOC-When-to-use-To-Be-Review... Later, once random order is default, a test that's flaky in random order which is causing failures in chromium.webkit (or other such master) could be marked flaky with TBR like this, I think. But this should usually be done in coordination with the current build sheriff, I think.
On 2016/12/08 at 17:50:51, qyearsley wrote: > On 2016/12/08 at 17:35:53, jeffcarp wrote: > > On 2016/12/08 at 17:27:07, commit-bot wrote: > > > No L-G-T-M from a valid reviewer yet. > > > CQ run can only be started by full committers or once the patch has > > > received an L-G-T-M from a full committer. > > > Even if an L-G-T-M may have been provided, it was from a non-committer, > > > _not_ a full super star committer. > > > See http://www.chromium.org/getting-involved/become-a-committer > > > Note that this has nothing to do with OWNERS files. > > > > Oops, tried to pull a "these are not the droids you're looking for" with TBR but I'm not a committer so it still needs a review. > > LGTM :-) > > Also, according to a strict reading of the official policy on TBR, I think that while this only affects FYI builds, we shouldn't use TBR to mark tests as flaky. > > "A developer (e.g. a sheriff) who is trying to correct a broken build can submit changes TBR=OWNER." > - https://www.chromium.org/developers/owners-files#TOC-When-to-use-To-Be-Review... > > Later, once random order is default, a test that's flaky in random order which is causing failures in chromium.webkit (or other such master) could be marked flaky with TBR like this, I think. But this should usually be done in coordination with the current build sheriff, I think. Ah ok thanks! I won't use it unless instructed by a build sheriff.
The CQ bit was checked by jeffcarp@chromium.org
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
CQ is committing da patch.
Bot data: {"patchset_id": 1, "attempt_start_ts": 1481219616936980, "parent_rev":
"cabb25d1376ab88440f756d19dfcd92efa2e5e91", "commit_rev":
"6788623a0a0b51635086481a1c684749f377319a"}
Message was sent while issue was closed.
Committed patchset #1 (id:1)
Message was sent while issue was closed.
Description was changed from ========== Add media/avtrack/video-track-selected.html to Windows RandomOrderExpectations It has failed 7 out of the last 20 builds. BUG=672204 ========== to ========== Add media/avtrack/video-track-selected.html to Windows RandomOrderExpectations It has failed 7 out of the last 20 builds. BUG=672204 Committed: https://crrev.com/1e3956252e91599da90cc454ea6cd7ccac7c97fa Cr-Commit-Position: refs/heads/master@{#437305} ==========
Message was sent while issue was closed.
Patchset 1 (id:??) landed as https://crrev.com/1e3956252e91599da90cc454ea6cd7ccac7c97fa Cr-Commit-Position: refs/heads/master@{#437305}
Message was sent while issue was closed.
On 2016/12/08 at 19:30:32, commit-bot wrote: > Patchset 1 (id:??) landed as https://crrev.com/1e3956252e91599da90cc454ea6cd7ccac7c97fa > Cr-Commit-Position: refs/heads/master@{#437305} It looks like this rule isn't being respected: https://luci-milo.appspot.com/buildbot/chromium.fyi/WebKit%20Win%20-%20Random... |
|||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||
