Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(623)

Unified Diff: content/browser/service_worker/service_worker_request_handler.cc

Issue 2562523003: Set the document URL of ServiceWorkerProviderHost when redirected even if skip_service_worker is set (Closed)
Patch Set: Created 4 years ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: content/browser/service_worker/service_worker_request_handler.cc
diff --git a/content/browser/service_worker/service_worker_request_handler.cc b/content/browser/service_worker/service_worker_request_handler.cc
index 02eafc2e7f8227e1676ecd920ea47441e923e5d4..c129326af91d449055c917b225c83c33e57d9634 100644
--- a/content/browser/service_worker/service_worker_request_handler.cc
+++ b/content/browser/service_worker/service_worker_request_handler.cc
@@ -67,20 +67,11 @@ void FinalizeHandlerInitialization(
RequestContextType request_context_type,
RequestContextFrameType frame_type,
scoped_refptr<ResourceRequestBodyImpl> body) {
- if (skip_service_worker) {
- // TODO(horo): Does this work properly for PlzNavigate?
- if (ServiceWorkerUtils::IsMainResourceType(resource_type)) {
- provider_host->SetDocumentUrl(net::SimplifyUrlForRequest(request->url()));
- provider_host->SetTopmostFrameUrl(request->first_party_for_cookies());
- }
- return;
- }
-
std::unique_ptr<ServiceWorkerRequestHandler> handler(
provider_host->CreateRequestHandler(
request_mode, credentials_mode, redirect_mode, resource_type,
request_context_type, frame_type, blob_storage_context->AsWeakPtr(),
- body));
+ body, skip_service_worker));
if (!handler)
return;

Powered by Google App Engine
This is Rietveld 408576698