Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(380)

Issue 2562523002: Add Histogram functionality. (Closed)

Created:
4 years ago by Robert Ogden
Modified:
4 years ago
Reviewers:
RyanSturm
CC:
chromium-reviews, tbansal+watch-data-reduction-proxy_chromium.org
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Add Histogram functionality. BUG=669956 Committed: https://crrev.com/c88a24e0808915994e09a47c4281b4cbf753c869 Cr-Commit-Position: refs/heads/master@{#437065}

Patch Set 1 #

Total comments: 2

Patch Set 2 : Fix nit. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+17 lines, -1 line) Patch
M tools/chrome_proxy/webdriver/common.py View 2 chunks +7 lines, -0 lines 0 comments Download
M tools/chrome_proxy/webdriver/simple_smoke.py View 1 2 chunks +10 lines, -1 line 0 comments Download

Messages

Total messages: 13 (7 generated)
Robert Ogden
4 years ago (2016-12-07 19:56:46 UTC) #3
RyanSturm
lgtm % nit https://codereview.chromium.org/2562523002/diff/1/tools/chrome_proxy/webdriver/simple_smoke.py File tools/chrome_proxy/webdriver/simple_smoke.py (right): https://codereview.chromium.org/2562523002/diff/1/tools/chrome_proxy/webdriver/simple_smoke.py#newcode30 tools/chrome_proxy/webdriver/simple_smoke.py:30: t.AddChromeArgs(['--enable-spdy-proxy-auth']) nit: s/AddChromeArgs(['--enable-spdy-proxy-auth'])/AddChromeArg('--enable-spdy-proxy-auth')/
4 years ago (2016-12-07 20:20:44 UTC) #4
Robert Ogden
https://codereview.chromium.org/2562523002/diff/1/tools/chrome_proxy/webdriver/simple_smoke.py File tools/chrome_proxy/webdriver/simple_smoke.py (right): https://codereview.chromium.org/2562523002/diff/1/tools/chrome_proxy/webdriver/simple_smoke.py#newcode30 tools/chrome_proxy/webdriver/simple_smoke.py:30: t.AddChromeArgs(['--enable-spdy-proxy-auth']) On 2016/12/07 20:20:44, Ryan Sturm wrote: > nit: ...
4 years ago (2016-12-07 21:11:53 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2562523002/20001
4 years ago (2016-12-07 21:12:29 UTC) #8
commit-bot: I haz the power
Committed patchset #2 (id:20001)
4 years ago (2016-12-07 21:28:59 UTC) #11
commit-bot: I haz the power
4 years ago (2016-12-07 21:32:21 UTC) #13
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/c88a24e0808915994e09a47c4281b4cbf753c869
Cr-Commit-Position: refs/heads/master@{#437065}

Powered by Google App Engine
This is Rietveld 408576698