Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1078)

Unified Diff: media/BUILD.gn

Issue 2562513003: Add opus dep to media pipeline_integration_test. (Closed)
Patch Set: change public_deps to plain deps. Created 4 years ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | media/test/BUILD.gn » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: media/BUILD.gn
diff --git a/media/BUILD.gn b/media/BUILD.gn
index 2d62c02ba673b121071d541e8281c47b0e852ead..807c4806e0ec9b9fef12b6a4a48fbc99bdcca9bd 100644
--- a/media/BUILD.gn
+++ b/media/BUILD.gn
@@ -648,7 +648,6 @@ source_set("unit_tests") {
}
if (media_use_ffmpeg) {
- deps += [ "//media/ffmpeg:ffmpeg_unittests" ]
sources += [
"filters/audio_decoder_unittest.cc",
"filters/audio_file_reader_unittest.cc",
@@ -658,6 +657,13 @@ source_set("unit_tests") {
"filters/in_memory_url_protocol_unittest.cc",
]
+ deps += [
+ "//media/ffmpeg:ffmpeg_unittests",
+
+ # Direct dependency needed for the config
+ "//third_party/opus",
+ ]
+
if (!is_android) {
sources += [
# FFmpeg on Android does not include video decoders.
@@ -737,6 +743,9 @@ test("media_unittests") {
"//media/mojo:unit_tests",
"//media/test:pipeline_integration_tests",
"//media/test:run_all_unittests",
+
+ # Direct dependency needed for the config
+ "//third_party/opus",
xhwang 2016/12/08 21:35:33 Why do we need this (from which test)?
mbjorge 2016/12/08 21:46:25 Oh, d'oh. I was confused on how the configs were w
]
if (is_android) {
« no previous file with comments | « no previous file | media/test/BUILD.gn » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698