Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1142)

Unified Diff: content/public/browser/web_contents_observer.h

Issue 2562503002: Generalize WebContentsObserver::SecurityStyleChanged (Closed)
Patch Set: Fix nit. Created 4 years ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « content/browser/web_contents/web_contents_impl.cc ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: content/public/browser/web_contents_observer.h
diff --git a/content/public/browser/web_contents_observer.h b/content/public/browser/web_contents_observer.h
index 77502effa5001bf50b23e2a7edbbab1ed302d4d7..6d945a20676b389f226a9e87771053abfd2c5f30 100644
--- a/content/public/browser/web_contents_observer.h
+++ b/content/public/browser/web_contents_observer.h
@@ -19,7 +19,6 @@
#include "ipc/ipc_listener.h"
#include "ipc/ipc_sender.h"
#include "third_party/WebKit/public/platform/WebInputEvent.h"
-#include "third_party/WebKit/public/platform/WebSecurityStyle.h"
#include "third_party/skia/include/core/SkColor.h"
#include "ui/base/page_transition_types.h"
#include "ui/base/window_open_disposition.h"
@@ -41,7 +40,6 @@ struct LoadCommittedDetails;
struct Referrer;
struct ResourceRedirectDetails;
struct ResourceRequestDetails;
-struct SecurityStyleExplanations;
// An observer API implemented by classes which are interested in various page
// load events from WebContents. They also get a chance to filter IPC messages.
@@ -297,13 +295,8 @@ class CONTENT_EXPORT WebContentsObserver : public IPC::Listener,
const base::string16& error_description,
bool was_ignored_by_handler) {}
- // This method is invoked when the SecurityStyle of the WebContents changes.
- // |security_style| is the new SecurityStyle. |security_style_explanations|
- // contains human-readable strings explaining why the SecurityStyle of the
- // page has been downgraded.
- virtual void SecurityStyleChanged(
- blink::WebSecurityStyle security_style,
- const SecurityStyleExplanations& security_style_explanations) {}
+ // This method is invoked when the visible security state of the page changes.
+ virtual void DidChangeVisibleSecurityState() {}
// This method is invoked when content was loaded from an in-memory cache.
virtual void DidLoadResourceFromMemoryCache(
« no previous file with comments | « content/browser/web_contents/web_contents_impl.cc ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698