Generalize WebContentsObserver::SecurityStyleChanged

content/public/browser/web_contents_observer.h

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #ifndef CONTENT_PUBLIC_BROWSER_WEB_CONTENTS_OBSERVER_H_
 #define CONTENT_PUBLIC_BROWSER_WEB_CONTENTS_OBSERVER_H_
 
 #include <stdint.h>
 
 #include "base/macros.h"
@@ skipping 23 matching lines @@
 class WebContents;
 class WebContentsImpl;
 struct AXEventNotificationDetails;
 struct AXLocationChangeNotificationDetails;
 struct FaviconURL;
 struct FrameNavigateParams;
 struct LoadCommittedDetails;
 struct Referrer;
 struct ResourceRedirectDetails;
 struct ResourceRequestDetails;
-struct SecurityStyleExplanations;
 
 // An observer API implemented by classes which are interested in various page
 // load events from WebContents.  They also get a chance to filter IPC messages.
 //
 // Since a WebContents can be a delegate to almost arbitrarily many
 // RenderViewHosts, it is important to check in those WebContentsObserver
 // methods which take a RenderViewHost that the event came from the
 // RenderViewHost the observer cares about.
 //
 // Usually, observers should only care about the current RenderViewHost as
@@ skipping 235 matching lines @@
                              const GURL& validated_url) {}
 
   // This method is like DidFinishLoad, but when the load failed or was
   // cancelled, e.g. window.stop() is invoked.
   virtual void DidFailLoad(RenderFrameHost* render_frame_host,
                            const GURL& validated_url,
                            int error_code,
                            const base::string16& error_description,
                            bool was_ignored_by_handler) {}
 
-  // This method is invoked when the SecurityStyle of the WebContents changes.
-  // |security_style| is the new SecurityStyle. |security_style_explanations|
-  // contains human-readable strings explaining why the SecurityStyle of the
-  // page has been downgraded.
-  virtual void SecurityStyleChanged(
-      blink::WebSecurityStyle security_style,
-      const SecurityStyleExplanations& security_style_explanations) {}
+  // This method is invoked when the visible security state of the page changes.
+  virtual void DidChangeVisibleSecurityState() {}

[clamy, 2016/12/09 14:25:44]

This method does not seem to be used outside of content/ except in unit tests.
Is that normal?

[cjgrant, 2016/12/09 16:08:29]

I've rebased this on top of CL 2556963006, which landed yesterday.  It shows
what VrShell is trying to achieve (ie. using a WebContentsObserver, but fishing
for security information that content isn't aware of).  I'm still trying to
grasp the detailed boundaries of the content API, and the previous comments on
this review help.  If you think I should be doing this differently, let me know!

[estark, 2016/12/09 16:12:44]

That's normal for WebContentsObserver methods, see e.g. OnWebContentsFocused,
AccessibilityEventReceived, BeforeUnloadFired, UserAgentOverrideSet, etc.

 
   // This method is invoked when content was loaded from an in-memory cache.
   virtual void DidLoadResourceFromMemoryCache(
       const GURL& url,
       const std::string& mime_type,
       ResourceType resource_type) {}
 
   // This method is invoked when a response has been received for a resource
   // request.
   virtual void DidGetResourceResponseStart(
@@ skipping 202 matching lines @@
   void ResetWebContents();
 
   WebContentsImpl* web_contents_;
 
   DISALLOW_COPY_AND_ASSIGN(WebContentsObserver);
 };
 
 }  // namespace content
 
 #endif  // CONTENT_PUBLIC_BROWSER_WEB_CONTENTS_OBSERVER_H_