Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(269)

Side by Side Diff: content/browser/web_contents/web_contents_impl.cc

Issue 2562503002: Generalize WebContentsObserver::SecurityStyleChanged (Closed)
Patch Set: Remove VrShell-specific changes from this CL. Created 4 years ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 // Copyright (c) 2012 The Chromium Authors. All rights reserved. 1 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #include "content/browser/web_contents/web_contents_impl.h" 5 #include "content/browser/web_contents/web_contents_impl.h"
6 6
7 #include <stddef.h> 7 #include <stddef.h>
8 8
9 #include <cmath> 9 #include <cmath>
10 #include <utility> 10 #include <utility>
(...skipping 1446 matching lines...) Expand 10 before | Expand all | Expand 10 after
1457 // TODO(ekaramad): Is it possible to have TextInputState before attaching to 1457 // TODO(ekaramad): Is it possible to have TextInputState before attaching to
1458 // outer WebContents? In such a case, is this still the right way to hand off 1458 // outer WebContents? In such a case, is this still the right way to hand off
1459 // state tracking from inner WebContents's TextInputManager to that of the 1459 // state tracking from inner WebContents's TextInputManager to that of the
1460 // outer WebContent (crbug.com/609846)? 1460 // outer WebContent (crbug.com/609846)?
1461 text_input_manager_.reset(nullptr); 1461 text_input_manager_.reset(nullptr);
1462 } 1462 }
1463 1463
1464 void WebContentsImpl::DidChangeVisibleSecurityState() { 1464 void WebContentsImpl::DidChangeVisibleSecurityState() {
1465 if (delegate_) { 1465 if (delegate_) {
1466 delegate_->VisibleSecurityStateChanged(this); 1466 delegate_->VisibleSecurityStateChanged(this);
1467
1468 SecurityStyleExplanations security_style_explanations;
1469 blink::WebSecurityStyle security_style =
1470 delegate_->GetSecurityStyle(this, &security_style_explanations);
1471 for (auto& observer : observers_) { 1467 for (auto& observer : observers_) {
clamy 2016/12/09 14:25:44 nit: remove curly braces, since the condition is n
cjgrant 2016/12/09 16:08:29 Done.
1472 observer.SecurityStyleChanged(security_style, 1468 observer.DidChangeVisibleSecurityState();
1473 security_style_explanations);
1474 } 1469 }
1475 } 1470 }
1476 } 1471 }
1477 1472
1478 void WebContentsImpl::Stop() { 1473 void WebContentsImpl::Stop() {
1479 for (FrameTreeNode* node : frame_tree_.Nodes()) 1474 for (FrameTreeNode* node : frame_tree_.Nodes())
1480 node->StopLoading(); 1475 node->StopLoading();
1481 for (auto& observer : observers_) 1476 for (auto& observer : observers_)
1482 observer.NavigationStopped(); 1477 observer.NavigationStopped();
1483 } 1478 }
(...skipping 3802 matching lines...) Expand 10 before | Expand all | Expand 10 after
5286 } 5281 }
5287 5282
5288 bool WebContentsImpl::AddDomainInfoToRapporSample(rappor::Sample* sample) { 5283 bool WebContentsImpl::AddDomainInfoToRapporSample(rappor::Sample* sample) {
5289 sample->SetStringField("Domain", ::rappor::GetDomainAndRegistrySampleFromGURL( 5284 sample->SetStringField("Domain", ::rappor::GetDomainAndRegistrySampleFromGURL(
5290 GetLastCommittedURL())); 5285 GetLastCommittedURL()));
5291 5286
5292 return true; 5287 return true;
5293 } 5288 }
5294 5289
5295 } // namespace content 5290 } // namespace content
OLDNEW

Powered by Google App Engine
This is Rietveld 408576698