Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(480)

Issue 2562493002: Revert of Disable dromaeo.jslibmodifyjquery on Windows (Closed)

Created:
4 years ago by Michael Lippautz
Modified:
4 years ago
Reviewers:
sullivan, fmeawad
CC:
chromium-reviews, telemetry-reviews_chromium.org, nednguyen
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Revert of Disable dromaeo.jslibmodifyjquery on Windows (patchset #1 id:1 of https://codereview.chromium.org/2557513006/ ) Reason for revert: Another fix landed in V8 5.7.155. https://codereview.chromium.org/2551973005/ Trying again Original issue's description: > Reland of Disable dromaeo.jslibmodifyjquery on Windows (patchset #1 id:1 of https://codereview.chromium.org/2532653002/ ) > > Reason for revert: > Still failing with wrapper tracing. Investigating. > > Original issue's description: > > Revert of Disable dromaeo.jslibmodifyjquery on Windows (patchset #1 id:1 of https://codereview.chromium.org/2529673003/ ) > > > > Reason for revert: > > Re-enable tests as we fixed a problem with wrapper tracing. > > > > Original issue's description: > > > Disable dromaeo.jslibmodifyjquery on Windows > > > > > > R=sullivan@chromium.org > > > BUG=668164 > > > CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.perf:linux_perf_cq;master.tryserver.chromium.perf:mac_retina_perf_cq;master.tryserver.chromium.perf:winx64_10_perf_cq > > > > > > Committed: https://crrev.com/98679f8f94d5beb4b7a0715edef85f8ba250f34b > > > Cr-Commit-Position: refs/heads/master@{#434268} > > > > TBR=sullivan@chromium.org,fmeawad@chromium.org > > # Not skipping CQ checks because original CL landed more than 1 days ago. > > BUG=668164 > > CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.perf:linux_perf_cq;master.tryserver.chromium.perf:mac_retina_perf_cq;master.tryserver.chromium.perf:winx64_10_perf_cq > > > > Committed: https://crrev.com/d74a3000970f43efa51287a3f7f5931abdfa1437 > > Cr-Commit-Position: refs/heads/master@{#434704} > > TBR=sullivan@chromium.org,fmeawad@chromium.org > # Not skipping CQ checks because original CL landed more than 1 days ago. > BUG=668164 > > Committed: https://crrev.com/6c485a2cf894fd6761fcd3e5ea4905ce773b96b5 > Cr-Commit-Position: refs/heads/master@{#436918} TBR=sullivan@chromium.org,fmeawad@chromium.org # Skipping CQ checks because original CL landed less than 1 days ago. NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=668164 Committed: https://crrev.com/61aaba1d8be432e52687ea4ff207342189d5d15d Cr-Commit-Position: refs/heads/master@{#437015}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+2 lines, -3 lines) Patch
M tools/perf/benchmarks/dromaeo.py View 1 chunk +2 lines, -3 lines 0 comments Download

Messages

Total messages: 9 (4 generated)
Michael Lippautz
Created Revert of Disable dromaeo.jslibmodifyjquery on Windows
4 years ago (2016-12-07 18:32:51 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2562493002/1
4 years ago (2016-12-07 18:33:06 UTC) #3
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years ago (2016-12-07 18:34:15 UTC) #6
commit-bot: I haz the power
Patchset 1 (id:??) landed as https://crrev.com/61aaba1d8be432e52687ea4ff207342189d5d15d Cr-Commit-Position: refs/heads/master@{#437015}
4 years ago (2016-12-07 18:37:47 UTC) #8
martiniss
4 years ago (2016-12-21 22:50:08 UTC) #9
Message was sent while issue was closed.
A revert of this CL (patchset #1 id:1) has been created in
https://codereview.chromium.org/2594173002/ by martiniss@chromium.org.

The reason for reverting is: Still failing on windows..

Powered by Google App Engine
This is Rietveld 408576698