Chromium Code Reviews
|
|
Chromium Code Reviews
Issue
2562463002:
Adding SwiftShader compilation to Linux (Closed)
DescriptionAdding SwiftShader compilation to Linux
This update contains the ubsan fix
BUG=630728
Committed: https://crrev.com/981bab182373a58cf7443f841d0dd2156563c98b
Cr-Commit-Position: refs/heads/master@{#437369}
Patch Set 1 #Patch Set 2 : Landing linux compilation with ubsan fix #Messages
Total messages: 25 (12 generated)
The CQ bit was checked by sugoi@chromium.org to run a CQ dry run
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
Description was changed from ========== Adding SwiftShader compilation to Linux This update contains the ubsan fix BUG=630728 ========== to ========== Adding SwiftShader compilation to Linux This update contains the ubsan fix BUG=630728 ==========
sugoi@chromium.org changed reviewers: + krasin@google.com, thakis@chromium.org
The CQ bit was unchecked by commit-bot@chromium.org
Dry run: This issue passed the CQ dry run.
Pinging reviewers.
On 2016/12/08 17:47:16, sugoi1 wrote: > Pinging reviewers. LGTM Note: it seems that no email had been sent about this CL yesterday. I have just received the first one with the ping message.
lgtm too. I too didn't receive anything before the ping, you must've forgot to "send email" the first time round.
On 2016/12/08 18:44:17, Nico wrote: > lgtm too. I too didn't receive anything before the ping, you must've forgot to > "send email" the first time round. Maybe. Thanks for quickly replying today, though!
The CQ bit was checked by sugoi@chromium.org
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
The CQ bit was unchecked by commit-bot@chromium.org
Try jobs failed on following builders: android_n5x_swarming_rel on master.tryserver.chromium.android (JOB_FAILED, https://build.chromium.org/p/tryserver.chromium.android/builders/android_n5x_...)
The CQ bit was checked by sugoi@chromium.org
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
CQ is committing da patch.
Bot data: {"patchset_id": 20001, "attempt_start_ts": 1481233002700590,
"parent_rev": "a8ac6182b89e8c1e9240903caeb1d2fd8238bbee", "commit_rev":
"66be63138b4bd350fb74f16f8a44a7089230be4e"}
Message was sent while issue was closed.
Description was changed from ========== Adding SwiftShader compilation to Linux This update contains the ubsan fix BUG=630728 ========== to ========== Adding SwiftShader compilation to Linux This update contains the ubsan fix BUG=630728 ==========
Message was sent while issue was closed.
Committed patchset #2 (id:20001)
Message was sent while issue was closed.
Description was changed from ========== Adding SwiftShader compilation to Linux This update contains the ubsan fix BUG=630728 ========== to ========== Adding SwiftShader compilation to Linux This update contains the ubsan fix BUG=630728 Committed: https://crrev.com/981bab182373a58cf7443f841d0dd2156563c98b Cr-Commit-Position: refs/heads/master@{#437369} ==========
Message was sent while issue was closed.
Patchset 2 (id:??) landed as https://crrev.com/981bab182373a58cf7443f841d0dd2156563c98b Cr-Commit-Position: refs/heads/master@{#437369}
Message was sent while issue was closed.
On 2016/12/08 22:41:00, commit-bot: I haz the power wrote: > Patchset 2 (id:??) landed as > https://crrev.com/981bab182373a58cf7443f841d0dd2156563c98b > Cr-Commit-Position: refs/heads/master@{#437369} This change broke Chromium Linux for MIPS build. clang: error: argument unused during compilation: '-msse2' [-Werror,-Wunused-command-line-argument] http://www.rt-rk.com/mips-buildbot/builders/build_and_test_chromium_trunk_for... Should SwiftShader building be disabled for non ia32/x64 architectures?
Message was sent while issue was closed.
On 2016/12/12 14:38:48, lmilko wrote: > On 2016/12/08 22:41:00, commit-bot: I haz the power wrote: > > Patchset 2 (id:??) landed as > > https://crrev.com/981bab182373a58cf7443f841d0dd2156563c98b > > Cr-Commit-Position: refs/heads/master@{#437369} > > This change broke Chromium Linux for MIPS build. > > clang: error: argument unused during compilation: '-msse2' > [-Werror,-Wunused-command-line-argument] > > http://www.rt-rk.com/mips-buildbot/builders/build_and_test_chromium_trunk_for... > > Should SwiftShader building be disabled for non ia32/x64 architectures? This can probably be fixed, but you can disable it for now if this causes an issue for you. Simply add the appropriate flags in the BUILD.gn file on the line modified in this cl. I have no problem with disabling it on these architectures for the time being.
Message was sent while issue was closed.
On 2016/12/12 15:08:49, sugoi1 wrote: > On 2016/12/12 14:38:48, lmilko wrote: > > On 2016/12/08 22:41:00, commit-bot: I haz the power wrote: > > > Patchset 2 (id:??) landed as > > > https://crrev.com/981bab182373a58cf7443f841d0dd2156563c98b > > > Cr-Commit-Position: refs/heads/master@{#437369} > > > > This change broke Chromium Linux for MIPS build. > > > > clang: error: argument unused during compilation: '-msse2' > > [-Werror,-Wunused-command-line-argument] > > > > > http://www.rt-rk.com/mips-buildbot/builders/build_and_test_chromium_trunk_for... > > > > Should SwiftShader building be disabled for non ia32/x64 architectures? > > This can probably be fixed, but you can disable it for now if this causes an > issue for you. Simply add the appropriate flags in the BUILD.gn file on the line > modified in this cl. I have no problem with disabling it on these architectures > for the time being. Made the cl to restrict compilation of SwiftShader to a few architectures here: https://codereview.chromium.org/2568283002/
Message was sent while issue was closed.
On 2016/12/12 20:58:38, sugoi1 wrote: > On 2016/12/12 15:08:49, sugoi1 wrote: > > On 2016/12/12 14:38:48, lmilko wrote: > > > On 2016/12/08 22:41:00, commit-bot: I haz the power wrote: > > > > Patchset 2 (id:??) landed as > > > > https://crrev.com/981bab182373a58cf7443f841d0dd2156563c98b > > > > Cr-Commit-Position: refs/heads/master@{#437369} > > > > > > This change broke Chromium Linux for MIPS build. > > > > > > clang: error: argument unused during compilation: '-msse2' > > > [-Werror,-Wunused-command-line-argument] > > > > > > > > > http://www.rt-rk.com/mips-buildbot/builders/build_and_test_chromium_trunk_for... > > > > > > Should SwiftShader building be disabled for non ia32/x64 architectures? > > > > This can probably be fixed, but you can disable it for now if this causes an > > issue for you. Simply add the appropriate flags in the BUILD.gn file on the > line > > modified in this cl. I have no problem with disabling it on these > architectures > > for the time being. > > Made the cl to restrict compilation of SwiftShader to a few architectures here: > https://codereview.chromium.org/2568283002/ Thanks. |
