third_party/WebKit/Source/devtools/front_end/sources/WatchExpressionsSidebarPane.js - Issue 2562453003: [DevTools] Remove Common.Event.target field.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/devtools/front_end/sources/WatchExpressionsSidebarPane.js

Issue 2562453003: [DevTools] Remove Common.Event.target field. (Closed)

Patch Set: works Created 4 years ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « third_party/WebKit/Source/devtools/front_end/sources/ThreadsSidebarPane.js ('k') | third_party/WebKit/Source/devtools/front_end/ui_lazy/DataGrid.js » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: third_party/WebKit/Source/devtools/front_end/sources/WatchExpressionsSidebarPane.js

diff --git a/third_party/WebKit/Source/devtools/front_end/sources/WatchExpressionsSidebarPane.js b/third_party/WebKit/Source/devtools/front_end/sources/WatchExpressionsSidebarPane.js

index fd346033580c18eb6a0cd6ded0b9991a8bafb5d2..0ef1d30f1e9be8a613707668f0add09a33539fe6 100644

--- a/third_party/WebKit/Source/devtools/front_end/sources/WatchExpressionsSidebarPane.js

+++ b/third_party/WebKit/Source/devtools/front_end/sources/WatchExpressionsSidebarPane.js

@@ -116,7 +116,7 @@ Sources.WatchExpressionsSidebarPane = class extends UI.ThrottledWidget {

this._emptyElement.classList.add('hidden');

var watchExpression = new Sources.WatchExpression(expression, this._expandController, this._linkifier);

watchExpression.addEventListener(

- Sources.WatchExpression.Events.ExpressionUpdated, this._watchExpressionUpdated.bind(this));

+ Sources.WatchExpression.Events.ExpressionUpdated, this._watchExpressionUpdated, this);

this._bodyElement.appendChild(watchExpression.element());

this._watchExpressions.push(watchExpression);

return watchExpression;

@@ -126,7 +126,7 @@ Sources.WatchExpressionsSidebarPane = class extends UI.ThrottledWidget {

* @param {!Common.Event} event

_watchExpressionUpdated(event) {

- var watchExpression = /** @type {!Sources.WatchExpression} */ (event.target);

+ var watchExpression = /** @type {!Sources.WatchExpression} */ (event.data);

if (!watchExpression.expression()) {

this._watchExpressions.remove(watchExpression);

this._bodyElement.removeChild(watchExpression.element());

@@ -304,7 +304,7 @@ Sources.WatchExpression = class extends Common.Object {

this._expandController.stopWatchSectionsWithId(this._expression);

this._expression = newExpression;

this.update();

- this.dispatchEventToListeners(Sources.WatchExpression.Events.ExpressionUpdated);

+ this.dispatchEventToListeners(Sources.WatchExpression.Events.ExpressionUpdated, this);

}

/**