Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(853)

Unified Diff: third_party/WebKit/Source/devtools/front_end/sources/SourcesPanel.js

Issue 2562453003: [DevTools] Remove Common.Event.target field. (Closed)
Patch Set: works Created 4 years ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: third_party/WebKit/Source/devtools/front_end/sources/SourcesPanel.js
diff --git a/third_party/WebKit/Source/devtools/front_end/sources/SourcesPanel.js b/third_party/WebKit/Source/devtools/front_end/sources/SourcesPanel.js
index fc305dd5e414cc5e5ea9690f1f5b449b288b1b78..b373530ba02943e58f2f9cc12dd555a28fd168cb 100644
--- a/third_party/WebKit/Source/devtools/front_end/sources/SourcesPanel.js
+++ b/third_party/WebKit/Source/devtools/front_end/sources/SourcesPanel.js
@@ -111,9 +111,11 @@ Sources.SourcesPanel = class extends UI.Panel {
SDK.targetManager.addModelListener(
SDK.DebuggerModel, SDK.DebuggerModel.Events.DebuggerPaused, this._debuggerPaused, this);
SDK.targetManager.addModelListener(
- SDK.DebuggerModel, SDK.DebuggerModel.Events.DebuggerResumed, this._debuggerResumed, this);
+ SDK.DebuggerModel, SDK.DebuggerModel.Events.DebuggerResumed,
+ (event) => this._debuggerResumed(/** @type {!SDK.DebuggerModel} */ (event.data)));
SDK.targetManager.addModelListener(
- SDK.DebuggerModel, SDK.DebuggerModel.Events.GlobalObjectCleared, this._debuggerReset, this);
+ SDK.DebuggerModel, SDK.DebuggerModel.Events.GlobalObjectCleared,
+ (event) => this._debuggerResumed(/** @type {!SDK.DebuggerModel} */ (event.data)));
SDK.targetManager.addModelListener(
SDK.SubTargetsManager, SDK.SubTargetsManager.Events.PendingTargetAdded, this._pendingTargetAdded, this);
new Sources.WorkspaceMappingTip(this, this._workspace);
@@ -288,7 +290,8 @@ Sources.SourcesPanel = class extends UI.Panel {
* @param {!Common.Event} event
*/
_debuggerPaused(event) {
- var details = /** @type {!SDK.DebuggerPausedDetails} */ (event.data);
+ var debuggerModel = /** @type {!SDK.DebuggerModel} */ (event.data);
+ var details = debuggerModel.debuggerPausedDetails();
if (!this._paused)
this._setAsCurrentPanel();
@@ -312,10 +315,9 @@ Sources.SourcesPanel = class extends UI.Panel {
}
/**
- * @param {!Common.Event} event
+ * @param {!SDK.DebuggerModel} debuggerModel
*/
- _debuggerResumed(event) {
- var debuggerModel = /** @type {!SDK.DebuggerModel} */ (event.target);
+ _debuggerResumed(debuggerModel) {
var target = debuggerModel.target();
if (UI.context.flavor(SDK.Target) !== target)
return;
@@ -329,21 +331,14 @@ Sources.SourcesPanel = class extends UI.Panel {
* @param {!Common.Event} event
*/
_debuggerWasEnabled(event) {
- var target = /** @type {!SDK.Target} */ (event.target.target());
- if (UI.context.flavor(SDK.Target) !== target)
+ var debuggerModel = /** @type {!SDK.DebuggerModel} */ (event.data);
+ if (UI.context.flavor(SDK.Target) !== debuggerModel.target())
return;
this._updateDebuggerButtonsAndStatus();
}
/**
- * @param {!Common.Event} event
- */
- _debuggerReset(event) {
- this._debuggerResumed(event);
- }
-
- /**
* @return {?UI.Widget}
*/
get visibleView() {

Powered by Google App Engine
This is Rietveld 408576698