Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(50)

Unified Diff: third_party/WebKit/Source/devtools/front_end/profiler/HeapSnapshotView.js

Issue 2562453003: [DevTools] Remove Common.Event.target field. (Closed)
Patch Set: works Created 4 years ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: third_party/WebKit/Source/devtools/front_end/profiler/HeapSnapshotView.js
diff --git a/third_party/WebKit/Source/devtools/front_end/profiler/HeapSnapshotView.js b/third_party/WebKit/Source/devtools/front_end/profiler/HeapSnapshotView.js
index 1a39579022b4208d51bcba6d34bac8da53f77009..f1d0beb12d96eb1252f64d94e835797514735ef8 100644
--- a/third_party/WebKit/Source/devtools/front_end/profiler/HeapSnapshotView.js
+++ b/third_party/WebKit/Source/devtools/front_end/profiler/HeapSnapshotView.js
@@ -440,20 +440,29 @@ Profiler.HeapSnapshotView = class extends UI.SimpleView {
this._dataGrid.populateContextMenu(contextMenu, event);
}
+ /**
+ * @param {!Common.Event} event
+ */
_selectionChanged(event) {
- var selectedNode = event.target.selectedNode;
+ var selectedNode = /** @type {!Profiler.HeapSnapshotGridNode} */ (event.data);
this._setSelectedNodeForDetailsView(selectedNode);
this._inspectedObjectChanged(event);
}
+ /**
+ * @param {!Common.Event} event
+ */
_onSelectAllocationNode(event) {
- var selectedNode = event.target.selectedNode;
+ var selectedNode = /** @type {!UI.DataGridNode} */ (event.data);
this._constructorsDataGrid.setAllocationNodeId(selectedNode.allocationNodeId());
this._setSelectedNodeForDetailsView(null);
}
+ /**
+ * @param {!Common.Event} event
+ */
_inspectedObjectChanged(event) {
- var selectedNode = event.target.selectedNode;
+ var selectedNode = /** @type {!UI.DataGridNode} */ (event.data);
var target = this._profile.target();
if (target && selectedNode instanceof Profiler.HeapSnapshotGenericObjectNode)
target.heapProfilerAgent().addInspectedHeapObject(String(selectedNode.snapshotNodeId));

Powered by Google App Engine
This is Rietveld 408576698