third_party/WebKit/Source/devtools/front_end/emulation/DeviceModeToolbar.js - Issue 2562453003: [DevTools] Remove Common.Event.target field.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/devtools/front_end/emulation/DeviceModeToolbar.js

Issue 2562453003: [DevTools] Remove Common.Event.target field. (Closed)

Patch Set: works Created 4 years ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « third_party/WebKit/Source/devtools/front_end/elements/ElementsTreeOutline.js ('k') | third_party/WebKit/Source/devtools/front_end/emulation/TouchModel.js » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: third_party/WebKit/Source/devtools/front_end/emulation/DeviceModeToolbar.js

diff --git a/third_party/WebKit/Source/devtools/front_end/emulation/DeviceModeToolbar.js b/third_party/WebKit/Source/devtools/front_end/emulation/DeviceModeToolbar.js

index b7dec58ff9d4436da9a4a750cd47d4f954ea6841..54fa80e72e892432fc029a735f7eeb4ae04d97cc 100644

--- a/third_party/WebKit/Source/devtools/front_end/emulation/DeviceModeToolbar.js

+++ b/third_party/WebKit/Source/devtools/front_end/emulation/DeviceModeToolbar.js

@@ -452,8 +452,8 @@ Emulation.DeviceModeToolbar = class {

}

var contextMenu = new UI.ContextMenu(

- /** @type {!Event} */ (event.data), false, event.target.element.totalOffsetLeft(),

- event.target.element.totalOffsetTop() + event.target.element.offsetHeight);

+ /** @type {!Event} */ (event.data), false, this._modeButton.element.totalOffsetLeft(),

+ this._modeButton.element.totalOffsetTop() + this._modeButton.element.offsetHeight);

addOrientation(Emulation.EmulatedDevice.Vertical, Common.UIString('Portrait'));

addOrientation(Emulation.EmulatedDevice.Horizontal, Common.UIString('Landscape'));

contextMenu.show();