Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(747)

Unified Diff: third_party/WebKit/Source/devtools/front_end/bindings/DebuggerWorkspaceBinding.js

Issue 2562453003: [DevTools] Remove Common.Event.target field. (Closed)
Patch Set: works Created 4 years ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: third_party/WebKit/Source/devtools/front_end/bindings/DebuggerWorkspaceBinding.js
diff --git a/third_party/WebKit/Source/devtools/front_end/bindings/DebuggerWorkspaceBinding.js b/third_party/WebKit/Source/devtools/front_end/bindings/DebuggerWorkspaceBinding.js
index 5d5080c9e73e4d3f63c3774e6b6dadbb402be413..1f9c3bca2e1a0f0f2466d3a92c96ed9024d7ece4 100644
--- a/third_party/WebKit/Source/devtools/front_end/bindings/DebuggerWorkspaceBinding.js
+++ b/third_party/WebKit/Source/devtools/front_end/bindings/DebuggerWorkspaceBinding.js
@@ -261,7 +261,7 @@ Bindings.DebuggerWorkspaceBinding = class {
* @param {!Common.Event} event
*/
_globalObjectCleared(event) {
- var debuggerModel = /** @type {!SDK.DebuggerModel} */ (event.target);
+ var debuggerModel = /** @type {!SDK.DebuggerModel} */ (event.data);
this._reset(debuggerModel.target());
}
@@ -322,7 +322,7 @@ Bindings.DebuggerWorkspaceBinding = class {
* @param {!Common.Event} event
*/
_debuggerResumed(event) {
- var debuggerModel = /** @type {!SDK.DebuggerModel} */ (event.target);
+ var debuggerModel = /** @type {!SDK.DebuggerModel} */ (event.data);
this._reset(debuggerModel.target());
}
};
@@ -395,9 +395,11 @@ Bindings.DebuggerWorkspaceBinding.TargetData = class {
else
this._uiSourceCodeToSourceMapping.remove(uiSourceCode);
- uiSourceCode.dispatchEventToListeners(
- Workspace.UISourceCode.Events.SourceMappingChanged,
- {target: this._debuggerModel.target(), isIdentity: sourceMapping ? sourceMapping.isIdentity() : false});
+ uiSourceCode.dispatchEventToListeners(Workspace.UISourceCode.Events.SourceMappingChanged, {
+ uiSourceCode: uiSourceCode,
+ target: this._debuggerModel.target(),
+ isIdentity: sourceMapping ? sourceMapping.isIdentity() : false
+ });
}
/**

Powered by Google App Engine
This is Rietveld 408576698