Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(43)

Side by Side Diff: third_party/WebKit/Source/devtools/front_end/sources/SourcesPanel.js

Issue 2562453003: [DevTools] Remove Common.Event.target field. (Closed)
Patch Set: works Created 4 years ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 /* 1 /*
2 * Copyright (C) 2008 Apple Inc. All Rights Reserved. 2 * Copyright (C) 2008 Apple Inc. All Rights Reserved.
3 * Copyright (C) 2011 Google Inc. All rights reserved. 3 * Copyright (C) 2011 Google Inc. All rights reserved.
4 * 4 *
5 * Redistribution and use in source and binary forms, with or without 5 * Redistribution and use in source and binary forms, with or without
6 * modification, are permitted provided that the following conditions 6 * modification, are permitted provided that the following conditions
7 * are met: 7 * are met:
8 * 1. Redistributions of source code must retain the above copyright 8 * 1. Redistributions of source code must retain the above copyright
9 * notice, this list of conditions and the following disclaimer. 9 * notice, this list of conditions and the following disclaimer.
10 * 2. Redistributions in binary form must reproduce the above copyright 10 * 2. Redistributions in binary form must reproduce the above copyright
(...skipping 93 matching lines...) Expand 10 before | Expand all | Expand 10 after
104 this._setTarget(UI.context.flavor(SDK.Target)); 104 this._setTarget(UI.context.flavor(SDK.Target));
105 Bindings.breakpointManager.addEventListener( 105 Bindings.breakpointManager.addEventListener(
106 Bindings.BreakpointManager.Events.BreakpointsActiveStateChanged, this._b reakpointsActiveStateChanged, this); 106 Bindings.BreakpointManager.Events.BreakpointsActiveStateChanged, this._b reakpointsActiveStateChanged, this);
107 UI.context.addFlavorChangeListener(SDK.Target, this._onCurrentTargetChanged, this); 107 UI.context.addFlavorChangeListener(SDK.Target, this._onCurrentTargetChanged, this);
108 UI.context.addFlavorChangeListener(SDK.DebuggerModel.CallFrame, this._callFr ameChanged, this); 108 UI.context.addFlavorChangeListener(SDK.DebuggerModel.CallFrame, this._callFr ameChanged, this);
109 SDK.targetManager.addModelListener( 109 SDK.targetManager.addModelListener(
110 SDK.DebuggerModel, SDK.DebuggerModel.Events.DebuggerWasEnabled, this._de buggerWasEnabled, this); 110 SDK.DebuggerModel, SDK.DebuggerModel.Events.DebuggerWasEnabled, this._de buggerWasEnabled, this);
111 SDK.targetManager.addModelListener( 111 SDK.targetManager.addModelListener(
112 SDK.DebuggerModel, SDK.DebuggerModel.Events.DebuggerPaused, this._debugg erPaused, this); 112 SDK.DebuggerModel, SDK.DebuggerModel.Events.DebuggerPaused, this._debugg erPaused, this);
113 SDK.targetManager.addModelListener( 113 SDK.targetManager.addModelListener(
114 SDK.DebuggerModel, SDK.DebuggerModel.Events.DebuggerResumed, this._debug gerResumed, this); 114 SDK.DebuggerModel, SDK.DebuggerModel.Events.DebuggerResumed,
115 (event) => this._debuggerResumed(/** @type {!SDK.DebuggerModel} */ (even t.data)));
115 SDK.targetManager.addModelListener( 116 SDK.targetManager.addModelListener(
116 SDK.DebuggerModel, SDK.DebuggerModel.Events.GlobalObjectCleared, this._d ebuggerReset, this); 117 SDK.DebuggerModel, SDK.DebuggerModel.Events.GlobalObjectCleared,
118 (event) => this._debuggerResumed(/** @type {!SDK.DebuggerModel} */ (even t.data)));
117 SDK.targetManager.addModelListener( 119 SDK.targetManager.addModelListener(
118 SDK.SubTargetsManager, SDK.SubTargetsManager.Events.PendingTargetAdded, this._pendingTargetAdded, this); 120 SDK.SubTargetsManager, SDK.SubTargetsManager.Events.PendingTargetAdded, this._pendingTargetAdded, this);
119 new Sources.WorkspaceMappingTip(this, this._workspace); 121 new Sources.WorkspaceMappingTip(this, this._workspace);
120 Extensions.extensionServer.addEventListener( 122 Extensions.extensionServer.addEventListener(
121 Extensions.ExtensionServer.Events.SidebarPaneAdded, this._extensionSideb arPaneAdded, this); 123 Extensions.ExtensionServer.Events.SidebarPaneAdded, this._extensionSideb arPaneAdded, this);
122 Components.DataSaverInfobar.maybeShowInPanel(this); 124 Components.DataSaverInfobar.maybeShowInPanel(this);
123 SDK.targetManager.observeTargets(this); 125 SDK.targetManager.observeTargets(this);
124 } 126 }
125 127
126 /** 128 /**
(...skipping 154 matching lines...) Expand 10 before | Expand all | Expand 10 after
281 * @return {!UI.SearchableView} 283 * @return {!UI.SearchableView}
282 */ 284 */
283 searchableView() { 285 searchableView() {
284 return this._sourcesView.searchableView(); 286 return this._sourcesView.searchableView();
285 } 287 }
286 288
287 /** 289 /**
288 * @param {!Common.Event} event 290 * @param {!Common.Event} event
289 */ 291 */
290 _debuggerPaused(event) { 292 _debuggerPaused(event) {
291 var details = /** @type {!SDK.DebuggerPausedDetails} */ (event.data); 293 var debuggerModel = /** @type {!SDK.DebuggerModel} */ (event.data);
294 var details = debuggerModel.debuggerPausedDetails();
292 if (!this._paused) 295 if (!this._paused)
293 this._setAsCurrentPanel(); 296 this._setAsCurrentPanel();
294 297
295 if (UI.context.flavor(SDK.Target) === details.target()) 298 if (UI.context.flavor(SDK.Target) === details.target())
296 this._showDebuggerPausedDetails(details); 299 this._showDebuggerPausedDetails(details);
297 else if (!this._paused) 300 else if (!this._paused)
298 UI.context.setFlavor(SDK.Target, details.target()); 301 UI.context.setFlavor(SDK.Target, details.target());
299 } 302 }
300 303
301 /** 304 /**
302 * @param {!SDK.DebuggerPausedDetails} details 305 * @param {!SDK.DebuggerPausedDetails} details
303 */ 306 */
304 _showDebuggerPausedDetails(details) { 307 _showDebuggerPausedDetails(details) {
305 this._paused = true; 308 this._paused = true;
306 this._updateDebuggerButtonsAndStatus(); 309 this._updateDebuggerButtonsAndStatus();
307 UI.context.setFlavor(SDK.DebuggerPausedDetails, details); 310 UI.context.setFlavor(SDK.DebuggerPausedDetails, details);
308 this._toggleDebuggerSidebarButton.setEnabled(false); 311 this._toggleDebuggerSidebarButton.setEnabled(false);
309 this._revealDebuggerSidebar(); 312 this._revealDebuggerSidebar();
310 window.focus(); 313 window.focus();
311 InspectorFrontendHost.bringToFront(); 314 InspectorFrontendHost.bringToFront();
312 } 315 }
313 316
314 /** 317 /**
315 * @param {!Common.Event} event 318 * @param {!SDK.DebuggerModel} debuggerModel
316 */ 319 */
317 _debuggerResumed(event) { 320 _debuggerResumed(debuggerModel) {
318 var debuggerModel = /** @type {!SDK.DebuggerModel} */ (event.target);
319 var target = debuggerModel.target(); 321 var target = debuggerModel.target();
320 if (UI.context.flavor(SDK.Target) !== target) 322 if (UI.context.flavor(SDK.Target) !== target)
321 return; 323 return;
322 this._paused = false; 324 this._paused = false;
323 this._clearInterface(); 325 this._clearInterface();
324 this._toggleDebuggerSidebarButton.setEnabled(true); 326 this._toggleDebuggerSidebarButton.setEnabled(true);
325 this._switchToPausedTargetTimeout = setTimeout(this._switchToPausedTarget.bi nd(this, debuggerModel), 500); 327 this._switchToPausedTargetTimeout = setTimeout(this._switchToPausedTarget.bi nd(this, debuggerModel), 500);
326 } 328 }
327 329
328 /** 330 /**
329 * @param {!Common.Event} event 331 * @param {!Common.Event} event
330 */ 332 */
331 _debuggerWasEnabled(event) { 333 _debuggerWasEnabled(event) {
332 var target = /** @type {!SDK.Target} */ (event.target.target()); 334 var debuggerModel = /** @type {!SDK.DebuggerModel} */ (event.data);
333 if (UI.context.flavor(SDK.Target) !== target) 335 if (UI.context.flavor(SDK.Target) !== debuggerModel.target())
334 return; 336 return;
335 337
336 this._updateDebuggerButtonsAndStatus(); 338 this._updateDebuggerButtonsAndStatus();
337 } 339 }
338 340
339 /** 341 /**
340 * @param {!Common.Event} event
341 */
342 _debuggerReset(event) {
343 this._debuggerResumed(event);
344 }
345
346 /**
347 * @return {?UI.Widget} 342 * @return {?UI.Widget}
348 */ 343 */
349 get visibleView() { 344 get visibleView() {
350 return this._sourcesView.visibleView(); 345 return this._sourcesView.visibleView();
351 } 346 }
352 347
353 /** 348 /**
354 * @param {!Workspace.UISourceCode} uiSourceCode 349 * @param {!Workspace.UISourceCode} uiSourceCode
355 * @param {number=} lineNumber 0-based 350 * @param {number=} lineNumber 0-based
356 * @param {number=} columnNumber 351 * @param {number=} columnNumber
(...skipping 957 matching lines...) Expand 10 before | Expand all | Expand 10 after
1314 */ 1309 */
1315 willHide() { 1310 willHide() {
1316 UI.inspectorView.setDrawerMinimized(false); 1311 UI.inspectorView.setDrawerMinimized(false);
1317 setImmediate(() => Sources.SourcesPanel.updateResizerAndSidebarButtons(Sourc es.SourcesPanel.instance())); 1312 setImmediate(() => Sources.SourcesPanel.updateResizerAndSidebarButtons(Sourc es.SourcesPanel.instance()));
1318 } 1313 }
1319 1314
1320 _showViewInWrapper() { 1315 _showViewInWrapper() {
1321 this._view.show(this.element); 1316 this._view.show(this.element);
1322 } 1317 }
1323 }; 1318 };
OLDNEW

Powered by Google App Engine
This is Rietveld 408576698