Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(396)

Side by Side Diff: third_party/WebKit/Source/devtools/front_end/sources/JavaScriptSourceFrame.js

Issue 2562453003: [DevTools] Remove Common.Event.target field. (Closed)
Patch Set: works Created 4 years ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 /* 1 /*
2 * Copyright (C) 2011 Google Inc. All rights reserved. 2 * Copyright (C) 2011 Google Inc. All rights reserved.
3 * 3 *
4 * Redistribution and use in source and binary forms, with or without 4 * Redistribution and use in source and binary forms, with or without
5 * modification, are permitted provided that the following conditions are 5 * modification, are permitted provided that the following conditions are
6 * met: 6 * met:
7 * 7 *
8 * * Redistributions of source code must retain the above copyright 8 * * Redistributions of source code must retain the above copyright
9 * notice, this list of conditions and the following disclaimer. 9 * notice, this list of conditions and the following disclaimer.
10 * * Redistributions in binary form must reproduce the above 10 * * Redistributions in binary form must reproduce the above
(...skipping 266 matching lines...) Expand 10 before | Expand all | Expand 10 after
277 contextMenu.appendItem(addSourceMapURLLabel, addSourceMapURL.bind(null , scriptFile)); 277 contextMenu.appendItem(addSourceMapURLLabel, addSourceMapURL.bind(null , scriptFile));
278 contextMenu.appendSeparator(); 278 contextMenu.appendSeparator();
279 } 279 }
280 } 280 }
281 } 281 }
282 282
283 return super.populateTextAreaContextMenu(contextMenu, lineNumber, columnNumb er) 283 return super.populateTextAreaContextMenu(contextMenu, lineNumber, columnNumb er)
284 .then(populateSourceMapMembers.bind(this)); 284 .then(populateSourceMapMembers.bind(this));
285 } 285 }
286 286
287 /**
288 * @param {!Common.Event} event
289 */
287 _workingCopyChanged(event) { 290 _workingCopyChanged(event) {
288 if (this._supportsEnabledBreakpointsWhileEditing() || this._scriptFileForTar get.size) 291 if (this._supportsEnabledBreakpointsWhileEditing() || this._scriptFileForTar get.size)
289 return; 292 return;
290 293
291 if (this.uiSourceCode().isDirty()) 294 if (this.uiSourceCode().isDirty())
292 this._muteBreakpointsWhileEditing(); 295 this._muteBreakpointsWhileEditing();
293 else 296 else
294 this._restoreBreakpointsAfterEditing(); 297 this._restoreBreakpointsAfterEditing();
295 } 298 }
296 299
300 /**
301 * @param {!Common.Event} event
302 */
297 _workingCopyCommitted(event) { 303 _workingCopyCommitted(event) {
298 this._scriptsPanel.updateLastModificationTime(); 304 this._scriptsPanel.updateLastModificationTime();
299 if (this._supportsEnabledBreakpointsWhileEditing()) 305 if (this._supportsEnabledBreakpointsWhileEditing())
300 return; 306 return;
301 307
302 if (!this._scriptFileForTarget.size) 308 if (!this._scriptFileForTarget.size)
303 this._restoreBreakpointsAfterEditing(); 309 this._restoreBreakpointsAfterEditing();
304 } 310 }
305 311
306 _didMergeToVM() { 312 _didMergeToVM() {
(...skipping 1065 matching lines...) Expand 10 before | Expand all | Expand 10 after
1372 hide() { 1378 hide() {
1373 if (!this.bookmark) 1379 if (!this.bookmark)
1374 return; 1380 return;
1375 this.bookmark.clear(); 1381 this.bookmark.clear();
1376 this.bookmark = null; 1382 this.bookmark = null;
1377 } 1383 }
1378 }; 1384 };
1379 1385
1380 Sources.JavaScriptSourceFrame.BreakpointDecoration.bookmarkSymbol = Symbol('book mark'); 1386 Sources.JavaScriptSourceFrame.BreakpointDecoration.bookmarkSymbol = Symbol('book mark');
1381 Sources.JavaScriptSourceFrame.BreakpointDecoration._elementSymbolForTest = Symbo l('element'); 1387 Sources.JavaScriptSourceFrame.BreakpointDecoration._elementSymbolForTest = Symbo l('element');
OLDNEW

Powered by Google App Engine
This is Rietveld 408576698