Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(494)

Side by Side Diff: third_party/WebKit/Source/devtools/front_end/console/ConsoleView.js

Issue 2562453003: [DevTools] Remove Common.Event.target field. (Closed)
Patch Set: works Created 4 years ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 /* 1 /*
2 * Copyright (C) 2007, 2008 Apple Inc. All rights reserved. 2 * Copyright (C) 2007, 2008 Apple Inc. All rights reserved.
3 * Copyright (C) 2009 Joseph Pecoraro 3 * Copyright (C) 2009 Joseph Pecoraro
4 * 4 *
5 * Redistribution and use in source and binary forms, with or without 5 * Redistribution and use in source and binary forms, with or without
6 * modification, are permitted provided that the following conditions 6 * modification, are permitted provided that the following conditions
7 * are met: 7 * are met:
8 * 8 *
9 * 1. Redistributions of source code must retain the above copyright 9 * 1. Redistributions of source code must retain the above copyright
10 * notice, this list of conditions and the following disclaimer. 10 * notice, this list of conditions and the following disclaimer.
(...skipping 191 matching lines...) Expand 10 before | Expand all | Expand 10 after
202 this); 202 this);
203 return; 203 return;
204 } 204 }
205 this._fetchMultitargetMessages(); 205 this._fetchMultitargetMessages();
206 } 206 }
207 207
208 /** 208 /**
209 * @param {!Common.Event} event 209 * @param {!Common.Event} event
210 */ 210 */
211 _onResourceTreeModelLoaded(event) { 211 _onResourceTreeModelLoaded(event) {
212 var resourceTreeModel = event.target; 212 var resourceTreeModel = /** @type {!SDK.ResourceTreeModel} */ (event.data);
213 if (resourceTreeModel.target() !== SDK.targetManager.mainTarget()) 213 if (resourceTreeModel.target() !== SDK.targetManager.mainTarget())
214 return; 214 return;
215 SDK.targetManager.removeModelListener( 215 SDK.targetManager.removeModelListener(
216 SDK.ResourceTreeModel, SDK.ResourceTreeModel.Events.CachedResourcesLoade d, this._onResourceTreeModelLoaded, 216 SDK.ResourceTreeModel, SDK.ResourceTreeModel.Events.CachedResourcesLoade d, this._onResourceTreeModelLoaded,
217 this); 217 this);
218 this._fetchMultitargetMessages(); 218 this._fetchMultitargetMessages();
219 } 219 }
220 220
221 _fetchMultitargetMessages() { 221 _fetchMultitargetMessages() {
222 SDK.multitargetConsoleModel.addEventListener(SDK.ConsoleModel.Events.Console Cleared, this._consoleCleared, this); 222 SDK.multitargetConsoleModel.addEventListener(SDK.ConsoleModel.Events.Console Cleared, this._consoleCleared, this);
(...skipping 1113 matching lines...) Expand 10 before | Expand all | Expand 10 after
1336 return true; 1336 return true;
1337 } 1337 }
1338 return false; 1338 return false;
1339 } 1339 }
1340 }; 1340 };
1341 1341
1342 /** 1342 /**
1343 * @typedef {{messageIndex: number, matchIndex: number}} 1343 * @typedef {{messageIndex: number, matchIndex: number}}
1344 */ 1344 */
1345 Console.ConsoleView.RegexMatchRange; 1345 Console.ConsoleView.RegexMatchRange;
OLDNEW

Powered by Google App Engine
This is Rietveld 408576698