Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(198)

Side by Side Diff: third_party/WebKit/Source/devtools/front_end/bindings/BreakpointManager.js

Issue 2562453003: [DevTools] Remove Common.Event.target field. (Closed)
Patch Set: works Created 4 years ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 /* 1 /*
2 * Copyright (C) 2011 Google Inc. All rights reserved. 2 * Copyright (C) 2011 Google Inc. All rights reserved.
3 * 3 *
4 * Redistribution and use in source and binary forms, with or without 4 * Redistribution and use in source and binary forms, with or without
5 * modification, are permitted provided that the following conditions are 5 * modification, are permitted provided that the following conditions are
6 * met: 6 * met:
7 * 7 *
8 * * Redistributions of source code must retain the above copyright 8 * * Redistributions of source code must retain the above copyright
9 * notice, this list of conditions and the following disclaimer. 9 * notice, this list of conditions and the following disclaimer.
10 * * Redistributions in binary form must reproduce the above 10 * * Redistributions in binary form must reproduce the above
(...skipping 155 matching lines...) Expand 10 before | Expand all | Expand 10 after
166 */ 166 */
167 _uiSourceCodeRemoved(event) { 167 _uiSourceCodeRemoved(event) {
168 var uiSourceCode = /** @type {!Workspace.UISourceCode} */ (event.data); 168 var uiSourceCode = /** @type {!Workspace.UISourceCode} */ (event.data);
169 this._removeUISourceCode(uiSourceCode); 169 this._removeUISourceCode(uiSourceCode);
170 } 170 }
171 171
172 /** 172 /**
173 * @param {!Common.Event} event 173 * @param {!Common.Event} event
174 */ 174 */
175 _uiSourceCodeMappingChanged(event) { 175 _uiSourceCodeMappingChanged(event) {
176 var uiSourceCode = /** @type {!Workspace.UISourceCode} */ (event.target); 176 var uiSourceCode = /** @type {!Workspace.UISourceCode} */ (event.data.uiSour ceCode);
177 var isIdentity = /** @type {boolean} */ (event.data.isIdentity); 177 var isIdentity = /** @type {boolean} */ (event.data.isIdentity);
178 var target = /** @type {!SDK.Target} */ (event.data.target); 178 var target = /** @type {!SDK.Target} */ (event.data.target);
179 if (isIdentity) 179 if (isIdentity)
180 return; 180 return;
181 var breakpoints = this._breakpointsForPrimaryUISourceCode.get(uiSourceCode) || []; 181 var breakpoints = this._breakpointsForPrimaryUISourceCode.get(uiSourceCode) || [];
182 for (var i = 0; i < breakpoints.length; ++i) 182 for (var i = 0; i < breakpoints.length; ++i)
183 breakpoints[i]._updateInDebuggerForTarget(target); 183 breakpoints[i]._updateInDebuggerForTarget(target);
184 } 184 }
185 185
186 /** 186 /**
(...skipping 901 matching lines...) Expand 10 before | Expand all | Expand 10 after
1088 this.url = breakpoint._url; 1088 this.url = breakpoint._url;
1089 this.lineNumber = breakpoint.lineNumber(); 1089 this.lineNumber = breakpoint.lineNumber();
1090 this.columnNumber = breakpoint.columnNumber(); 1090 this.columnNumber = breakpoint.columnNumber();
1091 this.condition = breakpoint.condition(); 1091 this.condition = breakpoint.condition();
1092 this.enabled = breakpoint.enabled(); 1092 this.enabled = breakpoint.enabled();
1093 } 1093 }
1094 }; 1094 };
1095 1095
1096 /** @type {!Bindings.BreakpointManager} */ 1096 /** @type {!Bindings.BreakpointManager} */
1097 Bindings.breakpointManager; 1097 Bindings.breakpointManager;
OLDNEW

Powered by Google App Engine
This is Rietveld 408576698