Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(225)

Issue 256233006: Revert of cc: Split animating and drawing into separate actions (Closed)

Created:
6 years, 7 months ago by Sami
Modified:
6 years, 7 months ago
CC:
chromium-reviews, cc-bugs_chromium.org, Ian Vollick
Visibility:
Public.

Description

Revert of cc: Split animating and drawing into separate actions (https://codereview.chromium.org/206793003/) Reason for revert: Broke some downstream unit tests. BUG=368064 TBR=skyostil@chromium.org Original issue's description: > cc: Split animating and drawing into separate actions > > Split impl-side animating and drawing into separate actions. This is > needed to allow for the possibility of a commit between animating and > drawing so that the main thread gets a chance to consume the new > animation state. In particular this allows the main thread to > synchronize with a fling animation using an onscroll handler. > > BUG=347366 > > Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=266624

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+114 lines, -432 lines) Patch
M cc/animation/layer_animation_controller.cc View 1 chunk +0 lines, -1 line 0 comments Download
M cc/input/input_handler.h View 1 chunk +1 line, -1 line 0 comments Download
M cc/scheduler/scheduler.h View 2 chunks +0 lines, -3 lines 0 comments Download
M cc/scheduler/scheduler.cc View 2 chunks +0 lines, -8 lines 0 comments Download
M cc/scheduler/scheduler_state_machine.h View 5 chunks +1 line, -8 lines 0 comments Download
M cc/scheduler/scheduler_state_machine.cc View 14 chunks +7 lines, -46 lines 0 comments Download
M cc/scheduler/scheduler_state_machine_unittest.cc View 31 chunks +0 lines, -111 lines 0 comments Download
M cc/scheduler/scheduler_unittest.cc View 17 chunks +16 lines, -36 lines 0 comments Download
M cc/test/fake_layer_tree_host_impl_client.h View 1 chunk +0 lines, -1 line 0 comments Download
M cc/trees/layer_tree_host_impl.h View 2 chunks +3 lines, -5 lines 0 comments Download
M cc/trees/layer_tree_host_impl.cc View 8 chunks +17 lines, -22 lines 0 comments Download
M cc/trees/layer_tree_host_impl_unittest.cc View 16 chunks +9 lines, -39 lines 0 comments Download
M cc/trees/layer_tree_host_unittest_animation.cc View 1 chunk +0 lines, -64 lines 0 comments Download
M cc/trees/single_thread_proxy.h View 1 chunk +0 lines, -1 line 0 comments Download
M cc/trees/single_thread_proxy.cc View 1 chunk +0 lines, -4 lines 0 comments Download
M cc/trees/thread_proxy.h View 3 chunks +3 lines, -10 lines 0 comments Download
M cc/trees/thread_proxy.cc View 6 chunks +15 lines, -30 lines 0 comments Download
M content/renderer/input/input_handler_proxy.cc View 3 chunks +3 lines, -3 lines 0 comments Download
M content/renderer/input/input_handler_proxy_unittest.cc View 34 chunks +39 lines, -39 lines 0 comments Download

Messages

Total messages: 8 (0 generated)
Sami
Created Revert of cc: Split animating and drawing into separate actions
6 years, 7 months ago (2014-04-29 12:14:24 UTC) #1
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/skyostil@chromium.org/256233006/1
6 years, 7 months ago (2014-04-29 12:14:30 UTC) #2
commit-bot: I haz the power
The CQ bit was unchecked by commit-bot@chromium.org
6 years, 7 months ago (2014-04-29 12:14:31 UTC) #3
commit-bot: I haz the power
No LGTM from a valid reviewer yet. Only full committers are accepted. Even if an ...
6 years, 7 months ago (2014-04-29 12:14:32 UTC) #4
Sami
The CQ bit was checked by skyostil@chromium.org
6 years, 7 months ago (2014-04-29 12:16:09 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/skyostil@chromium.org/256233006/1
6 years, 7 months ago (2014-04-29 12:16:22 UTC) #6
commit-bot: I haz the power
The CQ bit was unchecked by commit-bot@chromium.org
6 years, 7 months ago (2014-04-29 12:24:24 UTC) #7
commit-bot: I haz the power
6 years, 7 months ago (2014-04-29 12:24:24 UTC) #8
Try jobs failed on following builders:
  android_aosp on tryserver.chromium

Powered by Google App Engine
This is Rietveld 408576698