Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(31)

Issue 256233002: Ensure that modal dialogs from subframes can be cleaned up correctly. (Closed)

Created:
6 years, 7 months ago by Charlie Reis
Modified:
6 years, 7 months ago
Reviewers:
Avi (use Gerrit), sky
CC:
chromium-reviews, darin-cc_chromium.org, nasko+codewatch_chromium.org, jam, creis+watch_chromium.org, miu+watch_chromium.org
Visibility:
Public.

Description

Ensure that modal dialogs from subframes can be cleaned up correctly. BUG=366510 TEST=See bug comment 7 for repro steps. TBR=sky@chromium.org Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=266806

Patch Set 1 #

Patch Set 2 : Fix memory leak. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+54 lines, -10 lines) Patch
M chrome/browser/ui/browser_browsertest.cc View 1 chunk +27 lines, -0 lines 0 comments Download
M content/browser/renderer_host/render_view_host_impl.cc View 1 chunk +3 lines, -1 line 0 comments Download
M content/browser/web_contents/web_contents_impl.h View 1 chunk +5 lines, -2 lines 0 comments Download
M content/browser/web_contents/web_contents_impl.cc View 1 5 chunks +19 lines, -7 lines 0 comments Download

Messages

Total messages: 10 (0 generated)
Charlie Reis
Avi, can you take a look at the diff from patch set 1 (which matches ...
6 years, 7 months ago (2014-04-28 22:43:30 UTC) #1
Avi (use Gerrit)
LGTM
6 years, 7 months ago (2014-04-28 23:04:21 UTC) #2
Charlie Reis
Thanks. I suppose there's no point in waiting for the linux_valgrind or linux_asan try bots, ...
6 years, 7 months ago (2014-04-28 23:26:04 UTC) #3
Charlie Reis
The CQ bit was checked by creis@chromium.org
6 years, 7 months ago (2014-04-28 23:26:14 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/creis@chromium.org/256233002/20001
6 years, 7 months ago (2014-04-28 23:27:34 UTC) #5
commit-bot: I haz the power
The CQ bit was unchecked by commit-bot@chromium.org
6 years, 7 months ago (2014-04-28 23:46:26 UTC) #6
commit-bot: I haz the power
Try jobs failed on following builders: tryserver.chromium on linux_chromium_chromeos_rel
6 years, 7 months ago (2014-04-28 23:46:28 UTC) #7
Charlie Reis
The CQ bit was checked by creis@chromium.org
6 years, 7 months ago (2014-04-28 23:47:16 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/creis@chromium.org/256233002/20001
6 years, 7 months ago (2014-04-28 23:48:22 UTC) #9
commit-bot: I haz the power
6 years, 7 months ago (2014-04-29 09:38:30 UTC) #10
Message was sent while issue was closed.
Change committed as 266806

Powered by Google App Engine
This is Rietveld 408576698