Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1201)

Unified Diff: third_party/WebKit/Source/web/WebPagePopupImpl.cpp

Issue 2562323002: Devirtualize Frame::domWindow(). (Closed)
Patch Set: Created 4 years ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: third_party/WebKit/Source/web/WebPagePopupImpl.cpp
diff --git a/third_party/WebKit/Source/web/WebPagePopupImpl.cpp b/third_party/WebKit/Source/web/WebPagePopupImpl.cpp
index 86336bd70034ed14282ef74555f5b2e055d9abeb..f75540807ab011d538b0ffb69988dac7f5bdf0c1 100644
--- a/third_party/WebKit/Source/web/WebPagePopupImpl.cpp
+++ b/third_party/WebKit/Source/web/WebPagePopupImpl.cpp
@@ -304,7 +304,7 @@ bool WebPagePopupImpl::initializePage() {
m_popupClient->ownerElement().document().existingAXObjectCache())
cache->childrenChanged(&m_popupClient->ownerElement());
- DCHECK(frame->localDOMWindow());
+ DCHECK(frame->domWindow());
PagePopupSupplement::install(*frame, *this, m_popupClient);
DCHECK_EQ(m_popupClient->ownerElement().document().existingAXObjectCache(),
frame->document()->existingAXObjectCache());
@@ -322,8 +322,7 @@ void WebPagePopupImpl::postMessage(const String& message) {
if (!m_page)
return;
ScriptForbiddenScope::AllowUserAgentScript allowScript;
- if (LocalDOMWindow* window =
- toLocalFrame(m_page->mainFrame())->localDOMWindow())
+ if (LocalDOMWindow* window = toLocalFrame(m_page->mainFrame())->domWindow())
window->dispatchEvent(MessageEvent::create(message));
}
@@ -545,7 +544,7 @@ void WebPagePopupImpl::closePopup() {
}
LocalDOMWindow* WebPagePopupImpl::window() {
- return m_page->deprecatedLocalMainFrame()->localDOMWindow();
+ return m_page->deprecatedLocalMainFrame()->domWindow();
}
void WebPagePopupImpl::layoutAndPaintAsync(

Powered by Google App Engine
This is Rietveld 408576698