Devirtualize Frame::domWindow().

third_party/WebKit/Source/core/frame/LocalFrame.cpp

 /*
  * Copyright (C) 1998, 1999 Torben Weis <weis@kde.org>
  *                     1999 Lars Knoll <knoll@kde.org>
  *                     1999 Antti Koivisto <koivisto@kde.org>
  *                     2000 Simon Hausmann <hausmann@kde.org>
  *                     2000 Stefan Schimanski <1Stein@gmx.de>
  *                     2001 George Staikos <staikos@kde.org>
  * Copyright (C) 2004, 2005, 2006, 2007, 2008, 2009, 2010, 2011 Apple Inc. All
  * rights reserved.
  * Copyright (C) 2005 Alexey Proskuryakov <ap@nypop.com>
@@ skipping 331 matching lines @@
   visitor->trace(m_editor);
   visitor->trace(m_spellChecker);
   visitor->trace(m_selection);
   visitor->trace(m_eventHandler);
   visitor->trace(m_console);
   visitor->trace(m_inputMethodController);
   Frame::trace(visitor);
   Supplementable<LocalFrame>::trace(visitor);
 }
 
-DOMWindow* LocalFrame::domWindow() const {
-  return m_domWindow.get();
-}
-
 WindowProxy* LocalFrame::windowProxy(DOMWrapperWorld& world) {
   return m_script->windowProxy(world);
 }
 
 void LocalFrame::navigate(Document& originDocument,
                           const KURL& url,
                           bool replaceCurrentItem,
                           UserGestureStatus userGestureStatus) {
   m_navigationScheduler->scheduleLocationChange(
       &originDocument, url.getString(), replaceCurrentItem);
@@ skipping 56 matching lines @@
   m_loader.clear();
   if (!client())
     return;
 
   client()->willBeDetached();
   // Notify ScriptController that the frame is closing, since its cleanup ends
   // up calling back to FrameLoaderClient via WindowProxy.
   script().clearForClose();
   setView(nullptr);
 
-  m_host->eventHandlerRegistry().didRemoveAllEventHandlers(*localDOMWindow());
+  m_host->eventHandlerRegistry().didRemoveAllEventHandlers(*domWindow());
 
-  localDOMWindow()->frameDestroyed();
+  domWindow()->frameDestroyed();
 
   // TODO: Page should take care of updating focus/scrolling instead of Frame.
   // TODO: It's unclear as to why this is called more than once, but it is,
   // so page() could be null.
   if (page() && page()->focusController().focusedFrame() == this)
     page()->focusController().setFocusedFrame(nullptr);
 
   if (page() && page()->scrollingCoordinator() && m_view)
     page()->scrollingCoordinator()->willDestroyScrollableArea(m_view.get());
 
@@ skipping 22 matching lines @@
           ? "with URL '" +
                 toLocalFrame(targetFrame).document()->url().getString() + "'"
           : "with origin '" +
                 targetFrame.securityContext()->getSecurityOrigin()->toString() +
                 "'";
   String message =
       "Unsafe JavaScript attempt to initiate navigation for frame " +
       targetFrameDescription + " from frame with URL '" +
       document()->url().getString() + "'. " + reason + "\n";
 
-  localDOMWindow()->printErrorMessage(message);
+  domWindow()->printErrorMessage(message);
 }
 
 WindowProxyManager* LocalFrame::getWindowProxyManager() const {
   return m_script->getWindowProxyManager();
 }
 
 bool LocalFrame::shouldClose() {
   // TODO(dcheng): This should be fixed to dispatch beforeunload events to
   // both local and remote frames.
   return m_loader.shouldClose();
 }
 
 void LocalFrame::detachChildren() {
   DCHECK(m_loader.stateMachine()->creatingInitialEmptyDocument() || document());
 
   if (Document* document = this->document())
     ChildFrameDisconnector(*document).disconnect();
 }
 
 void LocalFrame::documentAttached() {
   DCHECK(document());
   selection().documentAttached(document());
   inputMethodController().documentAttached(document());
 }
 
+LocalDOMWindow* LocalFrame::domWindow() const {
+  return toLocalDOMWindow(m_domWindow);
+}
+
 void LocalFrame::setDOMWindow(LocalDOMWindow* domWindow) {
   // TODO(haraken): Update this comment.
   // Oilpan: setDOMWindow() cannot be used when finalizing. Which
   // is acceptable as its actions are either not needed or handled
   // by other means --
   //
   //  - LocalFrameLifecycleObserver::willDetachFrameHost() will have
   //    signalled the Inspector frameWindowDiscarded() notifications.
   //    We assume that all LocalFrames are detached, where that notification
   //    will have been done.
   //
   //  - Calling LocalDOMWindow::reset() is not needed (called from
   //    Frame::setDOMWindow().) The Member references it clears will now
   //    die with the window. And the registered DOMWindowProperty instances that
   //    don't, only keep a weak reference to this frame, so there's no need to
   //    be explicitly notified that this frame is going away.
   if (domWindow)
     script().clearWindowProxy();
 
-  if (m_domWindow)
-    m_domWindow->reset();
+  if (this->domWindow())
+    this->domWindow()->reset();
   m_domWindow = domWindow;

[haraken, 2016/12/12 09:54:59]

LocalFrame::m_domWindow is reset here. Where is RemoteFrame::m_domWindow reset?
Don't we need to reset in RemoteFrame::setView()?

[dcheng, 2016/12/12 10:21:39]

LocalDOMWindow is swapped on navigation, but RemoteDOMWindow is not: none of the
properties exposed by RemoteDOMWindow are affected by navigation.  We might want
to change this to address the inconsistency at some point, but at the time, it
didn't seem to add much value.

 }
 
 Document* LocalFrame::document() const {
   return m_domWindow ? m_domWindow->document() : nullptr;
 }
 
 void LocalFrame::setPagePopupOwner(Element& owner) {
   m_pagePopupOwner = &owner;
 }
 
@@ skipping 394 matching lines @@
   if (m_frame && m_frame->client() && m_frame->client()->frameBlameContext())
     m_frame->client()->frameBlameContext()->Enter();
 }
 
 ScopedFrameBlamer::~ScopedFrameBlamer() {
   if (m_frame && m_frame->client() && m_frame->client()->frameBlameContext())
     m_frame->client()->frameBlameContext()->Leave();
 }
 
 }  // namespace blink