Issue 256223003: Supervised users import: make sure users are up-to-date.

Issue 256223003: Supervised users import: make sure users are up-to-date. (Closed)

Created:
6 years, 7 months ago by Denis Kuznetsov (DE-MUC)

Modified:
6 years, 7 months ago

Reviewers:
Nikita (slow)

CC:
chromium-reviews, nkostylev+watch_chromium.org, pam+watch_chromium.org, arv+watch_chromium.org, oshima+watch_chromium.org, stevenjb+watch_chromium.org, davemoore+watch_chromium.org

Base URL:
svn://svn.chromium.org/chrome/trunk/src

Visibility:
Public.

More Reviews

Description

Supervised users import: make sure users are up-to-date. Cancel button should not be disabled. BUG=360589, 343076 R=nkostylev@chromium.org Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=267014

Patch Set 2 : Fixes #

Created: 6 years, 7 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+66 lines, -14 lines)			Patch
M	chrome/browser/chromeos/login/managed/locally_managed_user_creation_flow.h	View	1	1 chunk	+4 lines, -0 lines	0 comments	Download
M	chrome/browser/chromeos/login/managed/locally_managed_user_creation_flow.cc	View	1	3 chunks	+12 lines, -5 lines	0 comments	Download
M	chrome/browser/chromeos/login/managed/locally_managed_user_creation_screen.h	View		4 chunks	+10 lines, -0 lines	0 comments	Download
M	chrome/browser/chromeos/login/managed/locally_managed_user_creation_screen.cc	View	1	4 chunks	+14 lines, -4 lines	0 comments	Download
M	chrome/browser/resources/chromeos/login/screen_locally_managed_user_creation.js	View		5 chunks	+26 lines, -5 lines	0 comments	Download

Messages

Total messages: 5 (0 generated)

Expand Messages | Collapse Messages

Nikita (slow)

lgtm https://codereview.chromium.org/256223003/diff/1/chrome/browser/chromeos/login/managed/locally_managed_user_creation_screen.cc File chrome/browser/chromeos/login/managed/locally_managed_user_creation_screen.cc (right): https://codereview.chromium.org/256223003/diff/1/chrome/browser/chromeos/login/managed/locally_managed_user_creation_screen.cc#newcode349 chrome/browser/chromeos/login/managed/locally_managed_user_creation_screen.cc:349: sync_service_ = ManagedUserSyncServiceFactory::GetForProfile(manager_profile); nit: if (sync_service_) or CHECK(sync_service)?

6 years, 7 months ago (2014-04-29 14:03:40 UTC) #2

Denis Kuznetsov (DE-MUC)

The CQ bit was checked by antrim@chromium.org

6 years, 7 months ago (2014-04-29 18:14:12 UTC) #3

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/antrim@chromium.org/256223003/20001

6 years, 7 months ago (2014-04-29 18:15:02 UTC) #4

Message was sent while issue was closed.

Change committed as 267014

Expand Messages | Collapse Messages